Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wire delivery through to subscriptions #3146

Merged
merged 1 commit into from
May 18, 2020

Conversation

vaikas
Copy link
Contributor

@vaikas vaikas commented May 14, 2020

Fixes #2977

Proposed Changes

  • Propagate SequenceStep.Delivery to underlying Subscription.
  • Better error reporting in the status. Report the failed channel/subscription in the status.
  • add failure tests, which led to above point.

Release Note

- 🐛 Fix bug
Sequence now properly propagates the Delivery options to underlying Subscriptions.

Docs

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label May 14, 2020
@knative-prow-robot knative-prow-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 14, 2020
@knative-metrics-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-knative-eventing-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/sequence/sequence.go 70.6% 79.1% 8.5

@n3wscott
Copy link
Contributor

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label May 18, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: n3wscott, vaikas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vaikas
Copy link
Contributor Author

vaikas commented May 18, 2020

/test pull-knative-eventing-integration-tests

@vaikas
Copy link
Contributor Author

vaikas commented May 18, 2020

well, that's a new one:

error: error when retrieving current configuration of:
Resource: "rbac.authorization.k8s.io/v1, Resource=clusterroles", GroupVersionKind: "rbac.authorization.k8s.io/v1, Kind=ClusterRole"
Name: "eventing-broker-ingress", Namespace: ""
Object: &{map["apiVersion":"rbac.authorization.k8s.io/v1" "kind":"ClusterRole" "metadata":map["annotations":map["kubectl.kubernetes.io/last-applied-configuration":""] "labels":map["eventing.knative.dev/release":"devel"] "name":"eventing-broker-ingress"] "rules":[map["apiGroups":[""] "resources":["configmaps"] "verbs":["get" "list" "watch"]]]]}
from server for: "STDIN": Get https://35.238.155.91/apis/rbac.authorization.k8s.io/v1/clusterroles/eventing-broker-ingress: error executing access token command "/google-cloud-sdk/bin/gcloud config config-helper --format=json": err=exit status 1 output= stderr=ERROR: gcloud crashed (OperationalError): database is locked
If you would like to report this issue, please run the following command:
  gcloud feedback

@vaikas
Copy link
Contributor Author

vaikas commented May 18, 2020

/test pull-knative-eventing-integration-tests

@knative-prow-robot knative-prow-robot merged commit 6fe800e into knative:master May 18, 2020
@vaikas vaikas deleted the issue-2977 branch May 18, 2020 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sequence does not propagate delivery parameters
5 participants