Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

do not allow brokers to be created with channeltemplatespec #3083

Merged
merged 3 commits into from
May 5, 2020
Merged

do not allow brokers to be created with channeltemplatespec #3083

merged 3 commits into from
May 5, 2020

Conversation

vaikas
Copy link
Contributor

@vaikas vaikas commented May 4, 2020

Fixes #3066

Proposed Changes

  • Do not allow creation of new Brokers with ChannelTemplateSpec anymore

Release Note

- 🗑️ Remove feature or internal logic.
Creation of new Brokers using Spec.ChannelTemplate is now disallowed.
action required: Change broker creation workflow to use Spec.Config instead. While doing that, also switch to using v1beta1 Broker API.

Docs

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label May 4, 2020
@knative-prow-robot knative-prow-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. area/test-and-release Test infrastructure, tests or release labels May 4, 2020
@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 4, 2020
@matzew
Copy link
Member

matzew commented May 5, 2020

/assign

@knative-metrics-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-knative-eventing-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/eventing/v1alpha1/broker_validation.go 92.3% 93.8% 1.4

matzew
matzew reviewed May 5, 2020
View reviewed changes
pkg/apis/eventing/v1alpha1/broker_validation.go
// As of v0.15 do not allow creation of new Brokers with the channel template.
if apis.IsInCreate(ctx) {
if bs.ChannelTemplate != nil {
errs = errs.Also(apis.ErrDisallowedFields("channelTemplate"))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

log something? that the field is no loger allowed? not sure how known this really is?

matzew
matzew approved these changes May 5, 2020
View reviewed changes
Copy link
Member

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label May 5, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matzew, vaikas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit 03d6bf3 into knative:master May 5, 2020
@vaikas vaikas deleted the no-more-channel-templates-in-brokers branch May 5, 2020 18:12
@chizhg chizhg mentioned this pull request May 6, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matzew matzew matzew approved these changes

@liu-cong liu-cong Awaiting requested review from liu-cong

@yt3liu yt3liu Awaiting requested review from yt3liu

Assignees

@matzew matzew

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release Test infrastructure, tests or release cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Broker v1alpha1 -> v1beta1 storage & api plan
5 participants
@vaikas @matzew @knative-metrics-robot @knative-prow-robot @googlebot