Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix issue 3014 #3049

Merged
merged 5 commits into from
Apr 26, 2020
Merged

fix issue 3014 #3049

merged 5 commits into from
Apr 26, 2020

Conversation

vaikas
Copy link
Contributor

@vaikas vaikas commented Apr 25, 2020 •
edited
Loading

Fixes #3014

Proposed Changes

  • Return the correct duck shape for IMC. Before this, it would get defaulted to v1beta1 which means that even when read through the v1alpha1 API, it would lie and say it's a v1beta1 duck, which it's not. So, default to lowest version of the duck that we know, which is the same as the stored one, since when that is read through the API server no conversion hooks are invoked and hence we can't modify it. For up conversion to v1beta1, change the duck annotation to the one that it actually supports.
  • Also reduce the test timeouts from 4 minutes to 2 minutes.

Release Note

- 🐛 Fix bug - Fix issue #3014

Docs

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Apr 25, 2020
@knative-prow-robot knative-prow-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 25, 2020
@knative-prow-robot knative-prow-robot added the area/test-and-release Test infrastructure, tests or release label Apr 25, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vaikas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 25, 2020
@knative-metrics-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-knative-eventing-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/messaging/v1alpha1/in_memory_channel_conversion.go 97.5% 97.8% 0.3
pkg/reconciler/subscription/subscription.go 77.1% 79.1% 2.0

@sebgoa
Copy link

sebgoa commented Apr 26, 2020

I am not reviewing the code but doing a ko apply of this PR fixes the Trigger status. so for me it is lgtm

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 26, 2020
@knative-prow-robot knative-prow-robot merged commit 352fca4 into knative:master Apr 26, 2020
@sebgoa
Copy link

sebgoa commented Apr 26, 2020

oups, maybe I should not have that much karma :( looks like it got merged. I any case I think this fix should trigger a new release.

matzew
matzew reviewed Apr 27, 2020
View reviewed changes
Copy link
Member

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@matzew
Copy link
Member

matzew commented Apr 27, 2020

tested the fix, and it works

thanks

matzew pushed a commit to matzew/eventing that referenced this pull request Apr 27, 2020
@vaikas @matzew
fix issue 3014 (knative#3049)
cecedc8 
* fix issue 3014

* fix the unit tests and fix typo on the duck version

* really ville, really??

* deep copy before modifying

* do not blindly overwrite the subscribable in defaults, doh
lberk added a commit to lberk/eventing-contrib that referenced this pull request Apr 27, 2020
@lberk
Fix test builds
cd6024a 
knative/eventing#3049 added an extra parameter, add it to contrib tests
@lberk lberk mentioned this pull request Apr 27, 2020
Merged
knative-prow-robot pushed a commit to knative/eventing-contrib that referenced this pull request Apr 27, 2020
@lberk
Fix test builds (#1168)
420d1fa 
* Update deps hack/update-codgen.sh --upgrade && hack/update-deps.sh

* Fix test builds

knative/eventing#3049 added an extra parameter, add it to contrib tests

* channel test: don't override the apiversion (was a noop anyways)
knative-prow-robot pushed a commit that referenced this pull request Apr 28, 2020
@matzew @vaikas
fix issue 3014 (#3049) (#3052)
4a7a081 
* fix issue 3014

* fix the unit tests and fix typo on the duck version

* really ville, really??

* deep copy before modifying

* do not blindly overwrite the subscribable in defaults, doh

Co-authored-by: Ville Aikas <11279988+vaikas@users.noreply.github.com>
@vaikas vaikas mentioned this pull request May 6, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matzew matzew matzew left review comments

@grantr grantr Awaiting requested review from grantr

@steuhs steuhs Awaiting requested review from steuhs

Assignees

@sebgoa sebgoa

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release Test infrastructure, tests or release cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PhysicalChannelSyncFailed when mixing v1alpha1 and v1beta1 Subscriptions
6 participants
@vaikas @knative-prow-robot @knative-metrics-robot @sebgoa @matzew @googlebot