Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API Server Source: support non namespaced resources #2930

Merged
merged 5 commits into from
May 8, 2020
Merged

API Server Source: support non namespaced resources #2930

merged 5 commits into from
May 8, 2020

Conversation

odacremolbap
Copy link
Contributor

Fixes #2892

Release Note

- 🐛 Fix bug: API Server source supports now non-namespaced resources.

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Apr 7, 2020
@knative-prow-robot knative-prow-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 7, 2020
@knative-prow-robot
Copy link
Contributor

Hi @odacremolbap. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot knative-prow-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 7, 2020
@odacremolbap
Copy link
Contributor Author

/assign @vaikas

@n3wscott
Copy link
Contributor

n3wscott commented Apr 8, 2020

/ok-to-test

@knative-prow-robot knative-prow-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 8, 2020
@n3wscott
Copy link
Contributor

n3wscott commented Apr 8, 2020

COOL!!!

n3wscott
n3wscott reviewed Apr 8, 2020
View reviewed changes
pkg/adapter/apiserver/adapter.go Outdated
WatchFunc: asUnstructuredWatcher(a.k8s.Resource(r.GVR).Namespace(a.config.Namespace).Watch, r.LabelSelector),
for _, configRes := range a.config.Resources {

resources, err := a.kubeClient.Discovery().ServerResourcesForGroupVersion(configRes.GVR.GroupVersion().String())
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if this needs more RBAC? I have not used this call before.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discovery API is fairly open.

system:discovery cluster role is granted to system:authenticated by default (an I think that's a grant that admins cannot revoke).

@odacremolbap
Copy link
Contributor Author

/hold

forgot to check/add tests

@knative-prow-robot knative-prow-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 8, 2020
@knative-prow-robot knative-prow-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 8, 2020
mattmoor
mattmoor reviewed Apr 8, 2020
View reviewed changes
Copy link
Member

@mattmoor mattmoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Produced via:
gofmt -s -w $(find -path './vendor' -prune -o -path './third_party' -prune -o -type f -name '*.go' -print)

odacremolbap and others added 3 commits April 8, 2020 23:02
@odacremolbap @mattmoor
Update pkg/adapter/apiserver/adapter_test.go
6ab26ad 
Co-Authored-By: Matt Moore <mattmoor@vmware.com>
@odacremolbap @mattmoor
Update pkg/adapter/apiserver/adapter_test.go
3ce062d 
Co-Authored-By: Matt Moore <mattmoor@vmware.com>
@odacremolbap @mattmoor
Update pkg/adapter/apiserver/adapter_test.go
cfc0c7f 
Co-Authored-By: Matt Moore <mattmoor@vmware.com>
mattmoor
mattmoor reviewed Apr 8, 2020
View reviewed changes
Copy link
Member

@mattmoor mattmoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Produced via:
gofmt -s -w $(find -path './vendor' -prune -o -path './third_party' -prune -o -type f -name '*.go' -print)

mattmoor
mattmoor reviewed Apr 8, 2020
View reviewed changes
Copy link
Member

@mattmoor mattmoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Produced via:
gofmt -s -w $(find -path './vendor' -prune -o -path './third_party' -prune -o -type f -name '*.go' -print)

pkg/adapter/apiserver/adapter_test.go Show resolved Hide resolved
@odacremolbap
Copy link
Contributor Author

/unhold

@knative-prow-robot knative-prow-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 8, 2020
@vaikas
Copy link
Contributor

vaikas commented May 8, 2020

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label May 8, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: odacremolbap, vaikas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 8, 2020
@knative-prow-robot knative-prow-robot merged commit d76621b into knative:master May 8, 2020
@odacremolbap odacremolbap deleted the fix/allow-non-namespaced-resources branch May 8, 2020 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattmoor mattmoor mattmoor left review comments

@n3wscott n3wscott n3wscott left review comments

@grantr grantr Awaiting requested review from grantr

Assignees

@vaikas vaikas

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ApiServerSource does not seem to work with cluster scoped resources.
6 participants
@odacremolbap @knative-prow-robot @n3wscott @vaikas @mattmoor @googlebot