Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move CMP to knative-internal category #2887

Merged
merged 1 commit into from
Apr 1, 2020
Merged

Move CMP to knative-internal category #2887

merged 1 commit into from
Apr 1, 2020

Conversation

matzew
Copy link
Member

@matzew matzew commented Apr 1, 2020 •
edited
Loading

Proposed Changes

  • move cmp to just knative-internal category, like done on serving

@matzew matzew requested a review from grac3gao-zz April 1, 2020 08:12
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Apr 1, 2020
@knative-prow-robot knative-prow-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 1, 2020
@matzew matzew changed the title Move CMP to knative-internal category, like done on serving Move CMP to knative-internal category Apr 1, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 1, 2020
@lionelvillard
Copy link
Member

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 1, 2020
@knative-prow-robot knative-prow-robot merged commit 49789a8 into knative:master Apr 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grac3gao-zz grac3gao-zz Awaiting requested review from grac3gao-zz

@liu-cong liu-cong Awaiting requested review from liu-cong

@vaikas vaikas Awaiting requested review from vaikas

Assignees

@lionelvillard lionelvillard

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@matzew @knative-prow-robot @lionelvillard @googlebot