Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix pingsource label and add jobrunner grafana dashboard #2816

Merged
merged 1 commit into from
Mar 24, 2020
Merged

fix pingsource label and add jobrunner grafana dashboard #2816

merged 1 commit into from
Mar 24, 2020

Conversation

lionelvillard
Copy link
Member

Proposed Changes

  • Fix pingsource scrape job
  • Add JobRunner Grafana dashboard

Release Note

A new Grafana dashboard is provided to monitor PingSources backed by JobRunner

Docs

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Mar 23, 2020
@knative-prow-robot knative-prow-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 23, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lionelvillard

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 23, 2020
@nachocano
Copy link
Contributor

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 24, 2020
@lionelvillard
Copy link
Member Author

/test pull-knative-eventing-unit-tests

@knative-prow-robot knative-prow-robot merged commit a16613a into knative:master Mar 24, 2020
@lionelvillard lionelvillard deleted the fix-pingsource-metrics branch August 28, 2020 15:43
@lionelvillard lionelvillard restored the fix-pingsource-metrics branch September 3, 2020 15:41
@lionelvillard lionelvillard deleted the fix-pingsource-metrics branch September 3, 2020 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aslom aslom Awaiting requested review from aslom

@vaikas vaikas Awaiting requested review from vaikas

Assignees

@nachocano nachocano

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lionelvillard @knative-prow-robot @nachocano @googlebot