Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to latest pkg 0.13 #2727

Merged
merged 1 commit into from
Mar 7, 2020
Merged

Conversation

pmorie
Copy link
Member

@pmorie pmorie commented Mar 7, 2020

Brings in knative/pkg#1142 and knative/pkg#1145:

  • correct behavior when leader election config doesn't exist
  • fix problem with invalid prometheus metrics names with some controllers

Release Note

- correct behavior when leader election config doesn't exist
- fix problem with invalid prometheus metrics names with some controller names

@knative-prow-robot knative-prow-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 7, 2020
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Mar 7, 2020
@n3wscott
Copy link
Contributor

n3wscott commented Mar 7, 2020

/lgtm
/Approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 7, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: n3wscott, pmorie

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 7, 2020
@knative-prow-robot knative-prow-robot merged commit d14bc96 into knative:release-0.13 Mar 7, 2020
matzew pushed a commit to matzew/eventing that referenced this pull request Mar 10, 2020
openshift-merge-robot pushed a commit to openshift/knative-eventing that referenced this pull request Mar 11, 2020
Co-authored-by: Paul Morie <pmorie@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants