Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove 0.2 from the sources spec #2725

Merged
merged 1 commit into from
Mar 9, 2020
Merged

remove 0.2 from the sources spec #2725

merged 1 commit into from
Mar 9, 2020

Conversation

vaikas
Copy link
Contributor

@vaikas vaikas commented Mar 7, 2020

Fixes #2706

Proposed Changes

  • Remove 0.2 as supported Cloud Event version.

Release Note

- 🧽 Update or clean up current behavior : Cloud Events 0.2 is not supported by sources.

Docs

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Mar 7, 2020
@knative-prow-robot knative-prow-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 7, 2020
@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 7, 2020
matzew
matzew approved these changes Mar 9, 2020
View reviewed changes
Copy link
Member

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 9, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matzew, vaikas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit 724731f into knative:master Mar 9, 2020
@vaikas vaikas deleted the issue-2706 branch March 9, 2020 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matzew matzew matzew approved these changes

@liu-cong liu-cong Awaiting requested review from liu-cong

@n3wscott n3wscott Awaiting requested review from n3wscott

Assignees

@matzew matzew

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove CloudEvents v0.2 from Source spec
4 participants
@vaikas @knative-prow-robot @matzew @googlebot