Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default broker annotations from the broker defaults configmap #2724

Merged
merged 2 commits into from
Mar 8, 2020
Merged

Default broker annotations from the broker defaults configmap #2724

merged 2 commits into from
Mar 8, 2020

Conversation

vaikas
Copy link
Contributor

@vaikas vaikas commented Mar 7, 2020 •
edited
Loading

Fixes #

Proposed Changes

  • Add BrokerClass to Broker default configmap so that we can default BrokerClass on both cluster / namespace level.

Release Note

- 🎁 Add new feature : Add ability to specify how to default broker classes at both Cluster / Namespace level

Docs
knative/docs#2281

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Mar 7, 2020
@knative-prow-robot knative-prow-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Mar 7, 2020
@vaikas vaikas mentioned this pull request Mar 7, 2020
Closed
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vaikas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 7, 2020
mattmoor
mattmoor reviewed Mar 7, 2020
View reviewed changes
Copy link
Member

@mattmoor mattmoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Produced via:
gofmt -s -w $(find -path './vendor' -prune -o -path './third_party' -prune -o -type f -name '*.go' -print)

@knative-metrics-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-knative-eventing-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/config/defaults.go 80.0% 92.9% 12.9
pkg/apis/eventing/v1beta1/broker_defaults.go 0.0% 100.0% 100.0

@n3wscott
Copy link
Contributor

n3wscott commented Mar 8, 2020

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 8, 2020
@knative-prow-robot knative-prow-robot merged commit 6fd14a7 into knative:master Mar 8, 2020
@vaikas vaikas deleted the broker-class branch March 9, 2020 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattmoor mattmoor mattmoor left review comments

@liu-cong liu-cong Awaiting requested review from liu-cong

@yolocs yolocs Awaiting requested review from yolocs

Assignees

@n3wscott n3wscott

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@vaikas @knative-prow-robot @knative-metrics-robot @n3wscott @mattmoor @googlebot