Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kafka CRD Controller UT + Dispatcher tracing #1363

Merged
merged 8 commits into from
Jun 7, 2019
Merged

Kafka CRD Controller UT + Dispatcher tracing #1363

merged 8 commits into from
Jun 7, 2019

Conversation

nachocano
Copy link
Contributor

@nachocano nachocano commented Jun 6, 2019 •
edited
Loading

Proposed Changes

  • Adding UTs to the new Kafka CRD controller.
  • Needed a refactor to have our own reconciler, options, statsreporter, test factory, etc.
  • Adding Zipkin tracing

Release Note

NONE

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jun 6, 2019
@knative-prow-robot knative-prow-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jun 6, 2019
@nachocano
Copy link
Contributor Author

/assign @matzew
/assign @vaikas-google

@nachocano nachocano mentioned this pull request Jun 6, 2019
Closed
@nachocano nachocano changed the title Kafka CRD Controller UT Kafka CRD Controller UT + Dispatcher tracing Jun 6, 2019
@nachocano
Copy link
Contributor Author

in case you have some time...
/assign @Harwayne

This was referenced Jun 6, 2019
Closed
Closed
@nachocano
Copy link
Contributor Author

/test pull-knative-eventing-integration-tests

vaikas
vaikas reviewed Jun 7, 2019
View reviewed changes
Copy link
Contributor

@vaikas vaikas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just couple of small nits

contrib/kafka/pkg/reconciler/stats_reporter.go Outdated
const (
// KafkaChannelReadyCountN is the number of kafka channels that have become ready.
KafkaChannelReadyCountN = "kafkachannel_ready_count"
// KafkaChannelReadyCountN is the time it takes for a kafka channel to become ready since the resource is created.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: comment is wrong.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done, thanks!

contrib/kafka/pkg/reconciler/testing/kafkachannel.go Outdated Show resolved Hide resolved
@vaikas
Copy link
Contributor

vaikas commented Jun 7, 2019

/approve

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 7, 2019
@knative-metrics-robot
Copy link

The following is the coverage report on pkg/.
Say /test pull-knative-eventing-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
contrib/kafka/pkg/reconciler/controller/kafkachannel.go Do not exist 77.0%

@vaikas
Copy link
Contributor

vaikas commented Jun 7, 2019

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 7, 2019
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nachocano, vaikas-google

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit 2197863 into knative:master Jun 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vaikas vaikas vaikas left review comments

@bbrowning bbrowning Awaiting requested review from bbrowning

@matzew matzew Awaiting requested review from matzew

Assignees

@matzew matzew

@Harwayne Harwayne

@vaikas vaikas

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@nachocano @vaikas @knative-metrics-robot @knative-prow-robot @matzew @Harwayne @googlebot