Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broker is not ready until its constituent pieces are ready. #1064

Merged
merged 4 commits into from
Apr 19, 2019
Merged

Broker is not ready until its constituent pieces are ready. #1064

merged 4 commits into from
Apr 19, 2019

Conversation

Harwayne
Copy link
Contributor

@Harwayne Harwayne commented Apr 17, 2019 •
edited
Loading

Fixes #915

Proposed Changes

  • Broker is not ready until its constituent pieces are ready.
  • Emit Kubernetes events on every reconcile failure and when the Broker's readiness changes.

Release Note

NONE

@knative-prow-robot knative-prow-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 17, 2019
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Apr 17, 2019
@knative-prow-robot knative-prow-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 17, 2019
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Harwayne

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 17, 2019
@knative-metrics-robot
Copy link

The following is the coverage report on pkg/.
Say /test pull-knative-eventing-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/eventing/v1alpha1/broker_lifecycle.go Do not exist 95.0%
pkg/reconciler/v1alpha1/broker/broker.go 89.8% 90.2% 0.4

@Harwayne
Copy link
Contributor Author

/retest

@Harwayne Harwayne marked this pull request as ready for review April 18, 2019 04:31
@Harwayne Harwayne changed the title [WIP] Broker is not ready until its constituent pieces are ready. Broker is not ready until its constituent pieces are ready. Apr 18, 2019
@knative-prow-robot knative-prow-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 18, 2019
@n3wscott
Copy link
Contributor

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 19, 2019
@knative-prow-robot knative-prow-robot merged commit 3114f07 into knative:master Apr 19, 2019
@grantr grantr mentioned this pull request Apr 29, 2019
Closed
@Harwayne Harwayne deleted the broker-constituents branch May 9, 2019 18:56
lberk added a commit to lberk/eventing that referenced this pull request Jan 12, 2021
@lberk
Merge pull request knative#1064 from lberk/specific-wait-on-resources
3351032 
TestBrokerWithManyTriggers - add specific waits on resources patch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grantr grantr Awaiting requested review from grantr

@n3wscott n3wscott Awaiting requested review from n3wscott

Assignees

@n3wscott n3wscott

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Only Mark Broker Ready=True if all constituent pieces are Ready=True
5 participants
@Harwayne @knative-prow-robot @knative-metrics-robot @n3wscott @googlebot