Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eventing uses cluster-admin for webhook and controller, which is probably too powerful #749

Closed
n3wscott opened this issue Jan 24, 2019 · 3 comments
Closed

Eventing uses cluster-admin for webhook and controller, which is probably too powerful #749

n3wscott opened this issue Jan 24, 2019 · 3 comments
Assignees
@vaikas
Milestone
v0.5.0

Comments

@n3wscott
Copy link
Contributor

I think this is an oversight in our rbac config.

https://github.com/knative/serving/blob/ad35b282be64639873400e4ccea177c0a3bc0050/config/200-clusterrole.yaml#L17
@evankanderson
Copy link
Member

More specifically, we use cluster-admin instead of a specific set of roles:

https://github.com/knative/eventing/blob/master/config/201-clusterrolebinding.yaml

/milestone 0.4

@knative-prow-robot
Copy link
Contributor

@evankanderson: The provided milestone is not valid for this repository. Milestones in this repository: [v0.4.0]

Use /milestone clear to clear the milestone.

In response to this:

More specifically, we use cluster-admin instead of a specific set of roles:

https://github.com/knative/eventing/blob/master/config/201-clusterrolebinding.yaml

/milestone 0.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@evankanderson evankanderson changed the title Eventing does not give RBAC perms for creating mutatingwebhookconfigurations Eventing uses cluster-admin for webhook and controller, which is probably too powerful Jan 25, 2019
@evankanderson
Copy link
Member

/milestone v0.4.0

@knative-prow-robot knative-prow-robot added this to the v0.4.0 milestone Jan 25, 2019
@vaikas vaikas modified the milestones: v0.4.0, v0.5.0 Mar 6, 2019
@vaikas vaikas mentioned this issue Mar 8, 2019
Merged
@vaikas vaikas self-assigned this Mar 8, 2019
@evankanderson evankanderson mentioned this issue Mar 18, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vaikas vaikas

Labels
None yet
Projects
None yet
Milestone
v0.5.0
Development

No branches or pull requests
4 participants
@evankanderson @vaikas @n3wscott @knative-prow-robot