Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eventing TLS: migrate all resolver.URIResolver usages over to AddressableFromDestinationV1 #6878

Closed
pierDipi opened this issue Apr 20, 2023 · 2 comments · Fixed by #6883
Closed

Eventing TLS: migrate all resolver.URIResolver usages over to AddressableFromDestinationV1 #6878

pierDipi opened this issue Apr 20, 2023 · 2 comments · Fixed by #6883
Assignees
@vishal-chdhry
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature-request

Comments

@pierDipi
Copy link
Member

Problem

in knative/pkg#2714, we have implemented the algorithm described in the feature track, now, we need to migrate the usages of resolver.URIResolver over to use AddressableFromDestinationV1

Exit Criteria

Migrate all resolver.URIResolver usage over to AddressableFromDestinationV1

Time Estimate (optional):
How many developer-days do you think this may take to resolve?
1

Additional context (optional)

/good-first-issue
@knative-prow
Copy link

knative-prow bot commented Apr 20, 2023

@pierDipi:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

Problem

in knative/pkg#2714, we have implemented the algorithm described in the feature track, now, we need to migrate the usages of resolver.URIResolver over to use AddressableFromDestinationV1

Exit Criteria

Migrate all resolver.URIResolver usage over to AddressableFromDestinationV1

Time Estimate (optional):
How many developer-days do you think this may take to resolve?
1

Additional context (optional)

/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow knative-prow bot added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Apr 20, 2023
@pierDipi pierDipi changed the title Eventing TLS: migrate all resolver.URIResolver usage over to AddressableFromDestinationV1 Eventing TLS: migrate all resolver.URIResolver usages over to AddressableFromDestinationV1 Apr 20, 2023
@pierDipi pierDipi changed the title Eventing TLS: migrate all resolver.URIResolver usages over to AddressableFromDestinationV1 Eventing TLS: migrate all resolver.URIResolver usages over to AddressableFromDestinationV1 Apr 20, 2023
@vishal-chdhry vishal-chdhry mentioned this issue Apr 21, 2023
Merged
5 tasks
@vishal-chdhry
Copy link
Member

/assign

knative-prow bot pushed a commit that referenced this issue Apr 27, 2023
@vishal-chdhry @Rahul-Kumar-prog
@pierDipi @knative-automation
Eventing TLS: migrate all resolver.URIResolver usages over to Address…
6a5c7ee 
…ableFromDestinationV1 (#6883)

Fixes #6878

<!-- Please include the 'why' behind your changes if no issue exists -->

## Proposed Changes

<!-- Please categorize your changes:
- 🎁 Add new feature
- 🐛 Fix bug
- 🧹 Update or clean up current behavior
- 🗑️ Remove feature or internal logic
-->

- updated dependency to
`knative.dev/pkg@v0.0.0-20230420071539-300df436f953`

### Pre-review Checklist

<!-- If these boxes are not checked, you will be asked to complete these
requirements or explain why they do not apply to your PR. -->

- [x] **At least 80% unit test coverage**
- [x] **E2E tests** for any new behavior
- [ ] **Docs PR** for any user-facing impact
- [ ] **Spec PR** for any new API feature
- [ ] **Conformance test** for any change to the spec

**Release Note**

<!--
📄 If this change has user-visible impact, write a release
note in the block
below. Include the string "action required" if additional action is
required of
users switching to the new release, for example in case of a breaking
change.

Write as if you are speaking to users, not other Knative contributors.
If this
change has no user-visible impact, no release note is needed.
-->

```release-note

```


**Docs**

<!--
📖 If this change has user-visible impact, link to an issue or PR in
https://github.com/knative/docs.
-->

---------

Signed-off-by: Vishal Choudhary <sendtovishalchoudhary@gmail.com>
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
Signed-off-by: Knative Automation <automation@knative.team>
Co-authored-by: Rahul kumar <68837569+Rahul-Kumar-prog@users.noreply.github.com>
Co-authored-by: Pierangelo Di Pilato <pierdipi@redhat.com>
Co-authored-by: knative-automation <automation@knative.team>
@pierDipi pierDipi mentioned this issue May 26, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vishal-chdhry vishal-chdhry

Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature-request
Projects
No open projects
Eventing TLS
Status: ✅ Done
Milestone
No milestone
2 participants
@pierDipi @vishal-chdhry