Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default Broker delivery spec #5936

Closed
pierDipi opened this issue Nov 25, 2021 · 1 comment · Fixed by #6011
Closed

Change default Broker delivery spec #5936

pierDipi opened this issue Nov 25, 2021 · 1 comment · Fixed by #6011
Assignees
Labels
area/brokers area/delivery kind/feature-request priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. triage/accepted Issues which should be fixed (post-triage)
Milestone

Comments

@pierDipi
Copy link
Member

pierDipi commented Nov 25, 2021

Problem

Our Broker delivery spec is unset by default, which means that it has literally a
fire-and-forget delivery guarantee because with don't retry.

To make our defaults stronger, we should set a reasonable delivery spec
by default when no delivery spec is specified.

Default Delivery Spec

The following delivery spec isn't perfect for every use case by at least
prevents events loss for normal networking errors (eg connection resets, etc)
or during upgrades.

delivery:
  retry: 10
  backoffPolicy: exponential
  backoffDelay: PT0.2S

The retry period with the above configuration is ~200 seconds long

Persona:
Which persona is this feature for?

  • Event Consumer

Exit Criteria
A measurable (binary) test that would indicate that the problem has been resolved.

  • Our delivery spec is set by default if not specified

Time Estimate (optional):
How many developer days do you think this may take to resolve?
1

Additional context (optional)

/area broker
/area delivery
/kind feature-request
/priority important-soon

Let me know what you think!

@knative-prow-robot
Copy link
Contributor

@pierDipi: The label(s) area/broker cannot be applied, because the repository doesn't have them.

In response to this:

Problem

Our Broker delivery spec is unset by default, which means that it has literally a
fire-and-forget delivery guarantee because with don't retry.

To make our defaults stronger, we should set a reasonable delivery spec
by default when no delivery spec is specified.

Default Delivery Spec

The following delivery spec isn't perfect for every use case by at least
prevents events loss for normal networking errors (eg connection resets, etc)
or during upgrades.

delivery:
 retry: 10
 backoffPolicy: exponential
 backoffDelay: PT0.3S

The retry period with the above configuration is ~5min long
(ie the last retry is after about 5min)

Persona:
Which persona is this feature for?

  • Event Consumer

Exit Criteria
A measurable (binary) test that would indicate that the problem has been resolved.

  • Our delivery spec is set by default if not specified

Time Estimate (optional):
How many developer days do you think this may take to resolve?
1

Additional context (optional)

/area broker
/area delivery
/kind feature-request
/priority important-soon

Let me know what you think!

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot knative-prow-robot added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Nov 25, 2021
@devguyio devguyio added the triage/accepted Issues which should be fixed (post-triage) label Dec 15, 2021
@devguyio devguyio added this to the Backlog milestone Dec 15, 2021
@pierDipi pierDipi self-assigned this Dec 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/brokers area/delivery kind/feature-request priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. triage/accepted Issues which should be fixed (post-triage)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants