Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove use of finalizer in PingSource adapter #4986

Closed
lionelvillard opened this issue Feb 25, 2021 · 2 comments · Fixed by #5008
Closed

Remove use of finalizer in PingSource adapter #4986

lionelvillard opened this issue Feb 25, 2021 · 2 comments · Fixed by #5008
Assignees
@zhaojizhuang
Labels
area/sources kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/good-first-issue Denotes an issue ready for a new contributor. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Milestone
Backlog

Comments

@lionelvillard
Copy link
Member

Problem
The use of finalizers in the PingSource adapter is overkill since updating the internal state cannot fail.

Similar to #4509

Persona:
Which persona is this feature for?

Exit Criteria
A measurable (binary) test that would indicate that the problem has been resolved.

Time Estimate (optional):
How many developer-days do you think this may take to resolve?
<1

Additional context (optional)
Add any other context about the feature request here.
@lionelvillard lionelvillard added kind/feature-request kind/good-first-issue Denotes an issue ready for a new contributor. labels Feb 25, 2021
@lberk lberk added area/sources kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. and removed kind/feature-request labels Mar 1, 2021
@lberk
Copy link
Member

lberk commented Mar 1, 2021

If we remove the finalizers we have to make sure the existing finalizers are also removed. This might require a post-install job to ensure.

@lberk lberk added this to the Backlog milestone Mar 1, 2021
@zhaojizhuang
Copy link
Member

/assign

zhaojizhuang added a commit to zhaojizhuang/eventing that referenced this issue Mar 2, 2021
@zhaojizhuang
fix knative#4986 remove pingsource adapter
32513c9
@zhaojizhuang zhaojizhuang mentioned this issue Mar 2, 2021
Merged
zhaojizhuang added a commit to zhaojizhuang/eventing that referenced this issue Mar 2, 2021
@zhaojizhuang
fix knative#4986 remove pingsource adapter
2ababfc
zhaojizhuang added a commit to zhaojizhuang/eventing that referenced this issue Mar 2, 2021
@zhaojizhuang
fix knative#4986 remove pingsource adapter
4ddbae8
@zhaojizhuang zhaojizhuang mentioned this issue Mar 3, 2021
Merged
zhaojizhuang added a commit to zhaojizhuang/eventing that referenced this issue Mar 3, 2021
@zhaojizhuang
fix knative#4986 remove pingsource adapter
5b16d7d
zhaojizhuang added a commit to zhaojizhuang/eventing that referenced this issue Mar 3, 2021
@zhaojizhuang
fix knative#4986 remove pingsource adapter
712a3ea
zhaojizhuang added a commit to zhaojizhuang/eventing that referenced this issue Mar 8, 2021
@zhaojizhuang
fix knative#4986 remove pingsource adapter
446a52b
zhaojizhuang added a commit to zhaojizhuang/eventing that referenced this issue Mar 8, 2021
@zhaojizhuang
fix knative#4986 remove pingsource adapter
764edf1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zhaojizhuang zhaojizhuang

Labels
area/sources kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/good-first-issue Denotes an issue ready for a new contributor. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Projects
None yet
Milestone
Backlog
Development

Successfully merging a pull request may close this issue.

add post 022 job to remove pingsource finalizer zhaojizhuang/eventing
3 participants
@lberk @zhaojizhuang @lionelvillard