Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the Single tenant Broker #3139

Closed
5 tasks done
matzew opened this issue May 14, 2020 · 8 comments
Closed
5 tasks done

Remove the Single tenant Broker #3139

matzew opened this issue May 14, 2020 · 8 comments
Assignees
Milestone

Comments

@matzew
Copy link
Member

matzew commented May 14, 2020

For release 0.16 we remove the single tenant broker.

Background

With the advent of the multitenant broker class in v0.14 of Eventing, we now have an easier to use and less resource consuming broker. The creation for the mt broker is mostly done via injection/labeling and applying CR files, backing different implementations. No special ClusterRoles are needed for the “non default” broker.

Problem

Single-tenant broker creation is much harder if not using the “default” broker, as stated here. While with the multi-tenant

Proposal

@slinkydeveloper
Copy link
Contributor

👍 for targeting 0.16

@matzew
Copy link
Member Author

matzew commented May 14, 2020

/assign @matzew

@vaikas
Copy link
Contributor

vaikas commented May 14, 2020

I think we should also set the Broker status as deprecated with pointer to upgrade to other broker.
Something like this:
https://github.com/knative/eventing/pull/2374/files

@vaikas
Copy link
Contributor

vaikas commented May 26, 2020

I'll remove the ChannelBasedBroker

@vaikas vaikas closed this as completed May 26, 2020
@vaikas vaikas reopened this May 26, 2020
@vaikas
Copy link
Contributor

vaikas commented May 26, 2020

oops, just was going to comment, not close and comment :( :)

@matzew
Copy link
Member Author

matzew commented Jun 2, 2020

I keep it open util last two are merged.

doc and operator are pending

@matzew
Copy link
Member Author

matzew commented Jun 17, 2020

/close

all done

@knative-prow-robot
Copy link
Contributor

@matzew: Closing this issue.

In response to this:

/close

all done

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants