Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meta Channel doesn't conform the spec's status subscribers requirement #3037

Closed
aliok opened this issue Apr 22, 2020 · 6 comments
Closed

Meta Channel doesn't conform the spec's status subscribers requirement #3037

aliok opened this issue Apr 22, 2020 · 6 comments
Assignees
Labels
area/channels area/test-and-release Test infrastructure, tests or release kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Milestone

Comments

@aliok
Copy link
Member

aliok commented Apr 22, 2020

Describe the bug
As noted in #3016 (comment), Channel doesn't have subscribers in the status.

That PR is about adding conformance tests for channels around having subscribers array in the status.

Spec says this:

  • v1alpha1
    Each subscription to a channel is added to the channel
    status.subscribableStatus.subscribers automatically. The ready field of the
    subscriber identified by its uid MUST be set to True when the subscription
    is ready to be processed.
  • v1beta1
    Each subscription to a channel is added to the channel status.subscribers
    automatically. The ready field of the subscriber identified by its uid MUST
    be set to True when the subscription is ready to be processed.

When a channel.messaging.knative.dev is created, by default Knative creates an InMemoryChannel. When we create a subscription against that Channel, InMemoryChannel will have the subscribers in the status, but it is not propagated to channel.messaging.knative.dev. Other fields like status.address are propagated fine.

Expected behavior
channel.messaging.knative.dev should have status.subscribers and #3016 should pass.

To Reproduce

  • Create a channel.messaging.knative.dev
  • Create a subscription
  • No status.subscribers nor status.subscribableStatus.subscribers is there.

See #3016

Knative release version
0.14

Additional context
#3016

@aliok aliok added the kind/bug Categorizes issue or PR as related to a bug. label Apr 22, 2020
@aliok
Copy link
Member Author

aliok commented Apr 22, 2020

/area channels
/area test-and-release

@knative-prow-robot knative-prow-robot added area/channels area/test-and-release Test infrastructure, tests or release labels Apr 22, 2020
@aliok
Copy link
Member Author

aliok commented Apr 22, 2020

/project Channels

@knative-prow-robot
Copy link
Contributor

@aliok: You must be a member of the knative/eventing github team to set the project and column.

In response to this:

/project Channels

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@aliok aliok changed the title Meta Channel doesn't conform the spec's subscribers requirement Meta Channel doesn't conform the spec's status subscribers requirement Apr 27, 2020
@grantr grantr added this to the v0.15.0 milestone Apr 27, 2020
@grantr grantr added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Apr 27, 2020
@aliok
Copy link
Member Author

aliok commented Apr 30, 2020

Some info here: #3051 (comment)
That ticket is about the subscribers info in status, not in spec but it is also said that status should be propagated from the underlying channel to meta Channel

@aliok
Copy link
Member Author

aliok commented May 8, 2020

/close

Fixed by #3088

#3016 is now green

@knative-prow-robot
Copy link
Contributor

@aliok: Closing this issue.

In response to this:

/close

Fixed by #3088

#3016 is now green

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/channels area/test-and-release Test infrastructure, tests or release kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Development

No branches or pull requests

3 participants