Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perf: Configurable Broker implementation #2083

Closed
nachocano opened this issue Oct 23, 2019 · 2 comments
Closed

Perf: Configurable Broker implementation #2083

nachocano opened this issue Oct 23, 2019 · 2 comments

Comments

@nachocano
Copy link
Contributor

nachocano commented Oct 23, 2019

Problem
As of now, the Broker ingress and filter pods are k8s Deployments. When stress testing them, they keep on restarting due to liveness checks failures. Upon high traffic, we need to be able to scale these out.
We should be able to configure the underlying resources that a broker will use. @grantr suggested an annotation that enables us to either create Deployments or Knative Services. I agree with that approach.
This will have implications in metrics, and probably tracing as well.

Persona:
Which persona is this feature for?
Operator, Developer

Exit Criteria
Being able to configure whether to use Deployments or Knative Services as the underlying resources for Brokers.

Time Estimate (optional):
How many developer-days do you think this may take to resolve?
5 days

@n3wscott
Copy link
Contributor

/close
We have moved on to optional installable broker implementations. No config needed, install the Knative Serving based broker, if it existed.

@knative-prow-robot
Copy link
Contributor

@n3wscott: Closing this issue.

In response to this:

/close
We have moved on to optional installable broker implementations. No config needed, install the Knative Serving based broker, if it existed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants