Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Liveness and Readiness Checks for the Broker Ingress and Filter #1656

Closed
Harwayne opened this issue Aug 7, 2019 · 4 comments · Fixed by #1699
Closed

Liveness and Readiness Checks for the Broker Ingress and Filter #1656

Harwayne opened this issue Aug 7, 2019 · 4 comments · Fixed by #1699
Assignees
Milestone

Comments

@Harwayne
Copy link
Contributor

Harwayne commented Aug 7, 2019

Problem
The Broker Ingress and Filter Pods have no liveness or readiness checks. If for some reason, the HTTP server stops working, while the Pod is still running, the Broker will be broken until manual intervention by an operator to delete the Pod.

Persona:
Event Consumer

Exit Criteria
Liveness checks on both the Broker Ingress and Filter. Readiness check on the Broker Filter, that it only marks itself as ready if it can read the list of Triggers from the API server.

Additional context (optional)
Came about due to #1085.

@Harwayne
Copy link
Contributor Author

Harwayne commented Aug 7, 2019

/assign @grac3gao

@knative-prow-robot
Copy link
Contributor

@Harwayne: GitHub didn't allow me to assign the following users: grac3gao.

Note that only knative members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @grac3gao

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@grac3gao-zz
Copy link
Contributor

/assign @grac3gao

@akashrv
Copy link
Contributor

akashrv commented Aug 8, 2019

/milestone v0.9.0

@knative-prow-robot knative-prow-robot added this to the v0.9.0 milestone Aug 8, 2019
grac3gao-zz pushed a commit to grac3gao-zz/eventing that referenced this issue Aug 19, 2019
grac3gao-zz pushed a commit to grac3gao-zz/eventing that referenced this issue Aug 20, 2019
knative-prow-robot pushed a commit that referenced this issue Aug 20, 2019
…Filter (#1699)

* add liveness and readiness check for broker

* add liveness and readiness check for broker(#1656)

* add liveness and readiness check for broker(#1656)
aslom pushed a commit to aslom/eventing that referenced this issue Sep 5, 2019
…Filter (knative#1699)

* add liveness and readiness check for broker

* add liveness and readiness check for broker(knative#1656)

* add liveness and readiness check for broker(knative#1656)
mgencur pushed a commit to openshift-knative/eventing that referenced this issue Nov 14, 2022
…y-pick-1654-to-release-v0.26

[release-v0.26] [SRVKE-1181] Skip GPG check for kubernetes repository
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants