-
Notifications
You must be signed in to change notification settings - Fork 593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Liveness and Readiness Checks for the Broker Ingress and Filter #1656
Comments
/assign @grac3gao |
@Harwayne: GitHub didn't allow me to assign the following users: grac3gao. Note that only knative members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @grac3gao |
/milestone v0.9.0 |
…Filter (knative#1699) * add liveness and readiness check for broker * add liveness and readiness check for broker(knative#1656) * add liveness and readiness check for broker(knative#1656)
…y-pick-1654-to-release-v0.26 [release-v0.26] [SRVKE-1181] Skip GPG check for kubernetes repository
Problem
The Broker Ingress and Filter Pods have no liveness or readiness checks. If for some reason, the HTTP server stops working, while the Pod is still running, the Broker will be broken until manual intervention by an operator to delete the Pod.
Persona:
Event Consumer
Exit Criteria
Liveness checks on both the Broker Ingress and Filter. Readiness check on the Broker Filter, that it only marks itself as ready if it can read the list of Triggers from the API server.
Additional context (optional)
Came about due to #1085.
The text was updated successfully, but these errors were encountered: