Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Define a Spec for Channels, control and data plane #1213

Closed
vaikas opened this issue May 10, 2019 · 4 comments · Fixed by #1420
Closed

Define a Spec for Channels, control and data plane #1213

vaikas opened this issue May 10, 2019 · 4 comments · Fixed by #1420
Assignees
@matzew
Labels
kind/feature-request
Milestone
v0.8.0

Comments

@vaikas
Copy link
Contributor

vaikas commented May 10, 2019

Problem
Current Spec needs to be more well defined. We need to define the Control Plane spec (aka, what should the Spec be (Subscribable duck) as well as Status (Addressable, etc.). This needs to be spelled out so that we can then create Conformance Tests for Channels.

We also need to clearly define the dataplane contract (event formats, response codes, etc. etc.).

This becomes super important when we move the Channels out of the core and into the contrib repo.

Persona:
System Integrator (Channel Builder)

Exit Criteria
Spec that clearly defines the control and data plane for Channel implementors.

Time Estimate (optional):
14
@matzew
Copy link
Member

matzew commented May 14, 2019

/assign @matzew

@akashrv
Copy link
Contributor

akashrv commented May 15, 2019

/milestone v0.7.0

@knative-prow-robot knative-prow-robot added this to the v0.7.0 milestone May 15, 2019
@matzew matzew mentioned this issue May 20, 2019
Closed
@vaikas
Copy link
Contributor Author

vaikas commented Jun 15, 2019

As far as the CRDs go, we need to make sure that we also spec out:

  • channel-manipulator roles
  • label for subscribable:
    messaging.knative.dev/subscribable: "true"

Categories:

  • channelable type.

@matzew matzew mentioned this issue Jun 18, 2019
Merged
@grantr
Copy link
Contributor

grantr commented Jun 24, 2019

/milestone v0.8.0

@grantr grantr modified the milestones: v0.7.0, v0.8.0 Jun 24, 2019
matzew pushed a commit to matzew/eventing that referenced this issue Apr 23, 2021
@slinkydeveloper
KafkaChannel hack to upgrade (knative#5085) (knative#1213)
4a9951d 
* KafkaChannel hack

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

* This hack will do the trick?

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

* This is a proper hack

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

* fmt

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matzew matzew

Labels
kind/feature-request
Projects
None yet
Milestone
v0.8.0
Development

Successfully merging a pull request may close this issue.

Channel spec: iteration 1 matzew/eventing
5 participants
@grantr @matzew @vaikas @knative-prow-robot @akashrv