Skip to content

Commit

Permalink
Removes the deprecated DeadLetterChannel in ChannelableStatus (#6722)
Browse files Browse the repository at this point in the history
Signed-off-by: Vishal Choudhary <sendtovishalchoudhary@gmail.com>

Fixes #6720 

<!-- Please include the 'why' behind your changes if no issue exists -->

## Proposed Changes

<!-- Please catagorize your changes:
- 🎁 Add new feature
- 🐛 Fix bug
- 🧹 Update or clean up current behaviour
- 🗑️ Remove feature or internal logic
-->

-  🗑️ Remove feature or internal logic
- removes deprecated `DeadLetterChannel`
https://github.com/knative/eventing/blob/main/pkg/apis/duck/v1/channelable_types.go#L70-L74

### Pre-review Checklist

<!-- If these boxes are not checked, you will be asked to complete these
requirements or explain why they do not apply to your PR. -->

- [x] **At least 80% unit test coverage**
- [x] **E2E tests** for any new behavior
- [ ] **Docs PR** for any user-facing impact
- [ ] **Spec PR** for any new API feature
- [ ] **Conformance test** for any change to the spec

**Release Note**

<!--
:page_facing_up: If this change has user-visible impact, write a release
note in the block
below. Include the string "action required" if additional action is
required of
users switching to the new release, for example in case of a breaking
change.

Write as if you are speaking to users, not other Knative contributors.
If this
change has no user-visible impact, no release note is needed.
-->

```release-note
removes deprecated DeadLetterChannel in favor of DeliveryStatus
```


**Docs**

<!--
:book: If this change has user-visible impact, link to an issue or PR in
https://github.com/knative/docs.
-->

---------

Signed-off-by: Vishal Choudhary <sendtovishalchoudhary@gmail.com>
  • Loading branch information
vishal-chdhry authored Mar 2, 2023
1 parent c5847a9 commit 7d7df2d
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 26 deletions.
16 changes: 0 additions & 16 deletions docs/eventing-api.md
Original file line number Diff line number Diff line change
Expand Up @@ -282,22 +282,6 @@ DeliveryStatus
resolved delivery options.</p>
</td>
</tr>
<tr>
<td>
<code>deadLetterChannel</code><br/>
<em>
<a href="https://pkg.go.dev/knative.dev/pkg/apis/duck/v1#KReference">
knative.dev/pkg/apis/duck/v1.KReference
</a>
</em>
</td>
<td>
<em>(Optional)</em>
<p>DeadLetterChannel is a KReference and is set by the channel when it supports native error handling via a channel
Failed messages are delivered here.
Deprecated in favor of DeliveryStatus, to be removed September 2022.</p>
</td>
</tr>
</tbody>
</table>
<h3 id="duck.knative.dev/v1.DeliverySpec">DeliverySpec
Expand Down
5 changes: 0 additions & 5 deletions pkg/apis/duck/v1/channelable_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -67,11 +67,6 @@ type ChannelableStatus struct {
// resolved delivery options.
// +optional
DeliveryStatus `json:",inline"`
// DeadLetterChannel is a KReference and is set by the channel when it supports native error handling via a channel
// Failed messages are delivered here.
// Deprecated in favor of DeliveryStatus, to be removed September 2022.
// +optional
DeadLetterChannel *duckv1.KReference `json:"deadLetterChannel,omitempty"`
}

var (
Expand Down
5 changes: 0 additions & 5 deletions pkg/apis/duck/v1/zz_generated.deepcopy.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 7d7df2d

Please sign in to comment.