Skip to content

Commit

Permalink
Add deprecation warnings for EventType v1beta1 (#7453)
Browse files Browse the repository at this point in the history
* Change structure of crd versions for ET

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

* 💄 Add deprecation warning to v1beta1 resource version

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

---------

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
  • Loading branch information
matzew authored Nov 16, 2023
1 parent e5f2814 commit 203fa93
Showing 1 changed file with 9 additions and 4 deletions.
13 changes: 9 additions & 4 deletions config/core/resources/eventtype.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,9 @@ spec:
group: eventing.knative.dev
versions:
- &version
name: v1beta1
name: v1beta2
served: true
storage: true
storage: false
subresources:
status: {}
schema:
Expand Down Expand Up @@ -155,9 +155,14 @@ spec:
type: string
jsonPath: ".status.conditions[?(@.type==\"Ready\")].reason"
- <<: *version
name: v1beta2
name: v1beta1
served: true
storage: false
storage: true
# This indicates the v1beta1 version of the custom resource is deprecated.
# API requests to this version receive a warning header in the server response.
deprecated: true
# This overrides the default warning returned to API clients making v1beta1 API requests.
deprecationWarning: "eventing.knative.dev/v1beta1 EventType is deprecated; see https://knative.dev/docs/eventing/event-registry/ for instructions to migrate to eventing.knative.dev/v1beta2 EventType"
# v1beta1 schema is identical to the v1beta2 schema
names:
kind: EventType
Expand Down

0 comments on commit 203fa93

Please sign in to comment.