Remove 'master' where not necessary and add tracking issues. (#4022)

knative · Sep 9, 2020 · 163dab1 · 163dab1
1 parent 8e63db0
commit 163dab1
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/pkg/adapter/v2/cloudevents_test.go b/pkg/adapter/v2/cloudevents_test.go
@@ -32,7 +32,7 @@ type mockReporter struct {
 }
 
 var (
-	fakeMasterURL = "test-source"
+	fakeURL = "test-source"
 )
 
 func (r *mockReporter) ReportEventCount(args *source.ReportArgs, responseCode int) error {
@@ -70,7 +70,7 @@ func TestNewCloudEventsClient_send(t *testing.T) {
 	}
 	for n, tc := range testCases {
 		t.Run(n, func(t *testing.T) {
-			ceClient, err := NewCloudEventsClient(fakeMasterURL, tc.ceOverrides, &mockReporter{})
+			ceClient, err := NewCloudEventsClient(fakeURL, tc.ceOverrides, &mockReporter{})
 			if err != nil {
 				t.Fail()
 			}
@@ -125,7 +125,7 @@ func TestNewCloudEventsClient_request(t *testing.T) {
 	}
 	for n, tc := range testCases {
 		t.Run(n, func(t *testing.T) {
-			ceClient, err := NewCloudEventsClient(fakeMasterURL, tc.ceOverrides, &mockReporter{})
+			ceClient, err := NewCloudEventsClient(fakeURL, tc.ceOverrides, &mockReporter{})
 			if err != nil {
 				t.Fail()
 			}

diff --git a/test/lib/nodes/nodes.go b/test/lib/nodes/nodes.go
@@ -58,7 +58,7 @@ func (n *NodesClient) RandomWorkerNode() (*corev1.Node, error) {
 			" it must be a worker (Minikube, CRC)", node.Name)
 		return &node, nil
 	} else {
-		role := "master"
+		role := "master" // see https://github.com/kubernetes/kubeadm/issues/2200 for replacement.
 		n.logger.Infof("Filtering %d nodes, to not contain role: %s", nodesCount, role)
 		workers := FilterOutByRole(nodes.Items, role)
 		n.logger.Infof("Found %d worker(s)", len(workers))