This repository has been archived by the owner on Jun 4, 2021. It is now read-only.
Updating deps and setting krshapedlogic=false #1340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
knative-prow-robot
added
the
size/XXL
knative-prow-robot
requested review from
devguyio,
aslom,
lberk,
lionelvillard,
nicolaferraro,
rootfs,
syedriko and
tzununbekov
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: matzew The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
the
approved
|
/test pull-knative-eventing-contrib-unit-tests |
|
/assgin |
|
/lgtm |
|
/retest |
Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
matzew
changed the title
|
This is similar to @whaught did on different repos as well |
|
/lgtm |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Matthias Wessendorf mwessend@redhat.com
Fixes #
Proposed Changes
krshapedlogicexplicitly tofalse, since latest PKG (see Expect resources are krshaped by default pkg#1430) has enabled it by defaultNext
Each source/channel maintainer can decided to actually enable it - but current behavoir matches what we had anyways.
Release Note
Docs