Skip to content
This repository has been archived by the owner on Jun 4, 2021. It is now read-only.

Port Github source to adapter/v2 #1199

Closed
slinkydeveloper opened this issue May 6, 2020 · 3 comments · Fixed by #1230
Closed

Port Github source to adapter/v2 #1199

slinkydeveloper opened this issue May 6, 2020 · 3 comments · Fixed by #1230

Comments

@slinkydeveloper
Copy link
Contributor

Problem
Github source still uses knative.dev/eventing/pkg/adapter module, which uses the cloudevents/sdk-go v1. We should port it to knative.dev/eventing/pkg/adapter/v2, which uses the new sdk-go

Persona:
Event developer/Event producer

Exit Criteria
Github source should not use anymore knative.dev/eventing/pkg/adapter

Time Estimate (optional):
1

@MIBc
Copy link
Contributor

MIBc commented May 9, 2020

I can work on it.

@devguyio
Copy link
Contributor

devguyio commented May 14, 2020

@MIBc are you working on this? Just checking since it's not assigned and we wanted to move knative/eventing#3103

@MIBc
Copy link
Contributor

MIBc commented May 14, 2020

Yes. I will commit it as soon as possible.

MIBc added a commit to MIBc/eventing-contrib that referenced this issue May 14, 2020
MIBc added a commit to MIBc/eventing-contrib that referenced this issue May 18, 2020
MIBc added a commit to MIBc/eventing-contrib that referenced this issue May 23, 2020
MIBc added a commit to MIBc/eventing-contrib that referenced this issue May 25, 2020
MIBc added a commit to MIBc/eventing-contrib that referenced this issue May 25, 2020
MIBc added a commit to MIBc/eventing-contrib that referenced this issue May 25, 2020
knative-prow-robot pushed a commit that referenced this issue May 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants