Skip to content
This repository has been archived by the owner on Jun 4, 2021. It is now read-only.

Enable Tracing in Github source #1198

Closed
slinkydeveloper opened this issue May 6, 2020 · 8 comments
Closed

Enable Tracing in Github source #1198

slinkydeveloper opened this issue May 6, 2020 · 8 comments
Labels
area/observability good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature-request source/github

Comments

@slinkydeveloper
Copy link
Contributor

Problem
Enable Tracing configuration for Github source

Persona:
Event consumer/Event producer

Exit Criteria
Github source tracing works

Time Estimate (optional):
1

Additional context (optional)
In order to enable that, we just need to reflect the changes from knative/eventing#3026.

An example on how to do that is provided by these changes to apiserversource:

@MIBc
Copy link
Contributor

MIBc commented May 23, 2020

Let me try.

@slinkydeveloper
Copy link
Contributor Author

#1230 should be merged first

@github-actions
Copy link

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 10, 2020
@slinkydeveloper
Copy link
Contributor Author

/remove-lifecycle stale

/good-first-issue

@knative-prow-robot
Copy link
Contributor

@slinkydeveloper:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

/remove-lifecycle stale

/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot knative-prow-robot added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Sep 10, 2020
@github-actions
Copy link

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 10, 2020
@lionelvillard
Copy link
Member

/remove-lifecycle stale

@knative-prow-robot knative-prow-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 10, 2020
@lionelvillard
Copy link
Member

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/observability good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature-request source/github
Projects
None yet
Development

No branches or pull requests

6 participants