Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new CNCF case study to Knative website #5987

Merged
merged 3 commits into from
May 31, 2024
Merged

Add new CNCF case study to Knative website #5987

merged 3 commits into from
May 31, 2024

Conversation

rohitsrma
Copy link
Contributor

@rohitsrma rohitsrma commented May 22, 2024 •
edited
Loading

Fixes #5986

Homepage

image

Case studies list

image

IBM case study page

image

@knative-prow knative-prow bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 22, 2024
@netlify Netlify
Copy link

netlify bot commented May 22, 2024 •
edited
Loading

✅ Deploy Preview for knative ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit ece8922
🔍 Latest deploy log https://app.netlify.com/sites/knative/deploys/6657002ec860770008a1e26b
😎 Deploy Preview https://deploy-preview-5987--knative.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@shivansh-bhatnagar18 shivansh-bhatnagar18 mentioned this pull request May 22, 2024
Closed
aliok
aliok reviewed May 23, 2024
View reviewed changes
overrides/home.html Outdated Show resolved Hide resolved
aliok
aliok reviewed May 23, 2024
View reviewed changes
overrides/home.html Outdated Show resolved Hide resolved
aliok
aliok reviewed May 23, 2024
View reviewed changes
Copy link
Member

@aliok aliok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rohitsrma .

There are some changes I've requested

@rohitsrma
Copy link
Contributor Author

Hello @aliok, I've made the changes. Just have a little doubt here.

@knative-prow knative-prow bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 29, 2024
@rohitsrma
Copy link
Contributor Author

Hii @aliok, I've made the changes to display the latest three case studies on the homepage. These case studies are also listed on the CNFC website.

image

Please let me know if any further changes are needed.

@aliok
Copy link
Member

aliok commented May 31, 2024

Thanks a lot @rohitsrma

Merging this now!

aliok
aliok approved these changes May 31, 2024
View reviewed changes
Copy link
Member

@aliok aliok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label May 31, 2024
@knative-prow Knative Prow
Copy link

knative-prow bot commented May 31, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aliok, rohitsrma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 31, 2024
@aliok aliok mentioned this pull request May 31, 2024
Merged
@knative-prow knative-prow bot merged commit ab1e7b2 into knative:main May 31, 2024
19 checks passed
@nrrso nrrso mentioned this pull request Aug 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aliok aliok aliok approved these changes

@csantanapr csantanapr Awaiting requested review from csantanapr

@ReToCode ReToCode Awaiting requested review from ReToCode

Assignees

@aliok aliok

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add new CNCF case study to Knative website
2 participants
@rohitsrma @aliok