Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document the remaining timeout settings #5954

Merged
merged 2 commits into from
Apr 30, 2024
Merged

Document the remaining timeout settings #5954

merged 2 commits into from
Apr 30, 2024

Conversation

skonto
Copy link
Contributor

@skonto skonto commented Apr 29, 2024

"Fixes #issue-number" or "Add description of the problem this PR solves"

Proposed Changes

@knative-prow knative-prow bot requested review from csantanapr and nainaz April 29, 2024 14:29
@knative-prow knative-prow bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 29, 2024
@netlify Netlify
Copy link

netlify bot commented Apr 29, 2024 •
edited
Loading

✅ Deploy Preview for knative ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit ab0b0da
🔍 Latest deploy log https://app.netlify.com/sites/knative/deploys/662faeda8195fc000892a316
😎 Deploy Preview https://deploy-preview-5954--knative.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@skonto
Copy link
Contributor Author

skonto commented Apr 29, 2024

/assign @ReToCode

ReToCode
ReToCode approved these changes Apr 30, 2024
View reviewed changes
Copy link
Member

@ReToCode ReToCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Apr 30, 2024
@knative-prow Knative Prow
Copy link

knative-prow bot commented Apr 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ReToCode, skonto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit ab85e25 into knative:main Apr 30, 2024
19 checks passed
prushh pushed a commit to prushh/docs that referenced this pull request Apr 30, 2024
@skonto @prushh
Document the remaining timeout settings (knative#5954)
ac49fbc 
* document the remaining timeout settings

* fix name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ReToCode ReToCode ReToCode approved these changes

@csantanapr csantanapr Awaiting requested review from csantanapr

@nainaz nainaz Awaiting requested review from nainaz

Assignees

@ReToCode ReToCode

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@skonto @ReToCode