Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added mention of channels to event type autocreate docs #5639

Conversation

Cali0707
Copy link
Member

This adds mention of eventtype auto create supporting the channel as well as the broker.

Proposed Changes

  • Mention the channel when discussing event type autocreate working with brokers
  • Make the Broker section subsections of the example, so that it is clear that this is only an example, and you don't need to use a Broker

Signed-off-by: Calum Murray <cmurray@redhat.com>
@knative-prow knative-prow bot requested review from nak3 and pierDipi July 26, 2023 13:12
@netlify
Copy link

netlify bot commented Jul 26, 2023

Deploy Preview for knative ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 669a9bf
🔍 Latest deploy log https://app.netlify.com/sites/knative/deploys/64c11bac158c6e0007211ec5
😎 Deploy Preview https://deploy-preview-5639--knative.netlify.app/docs/eventing/experimental-features/eventtype-auto-creation
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Cali0707
Copy link
Member Author

/cc @matzew

@knative-prow knative-prow bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 26, 2023
@knative-prow knative-prow bot requested a review from matzew July 26, 2023 13:12
@Cali0707
Copy link
Member Author

@matzew do you think it is worth adding an example of using this with a channel as well, or is this enough to show that it works with channels as well?

@dsimansk
Copy link
Contributor

@matzew do you think it is worth adding an example of using this with a channel as well, or is this enough to show that it works with channels as well?

Have we done channel auto-create implementation yet? Because my PR was only on broker ingress.

@Cali0707
Copy link
Member Author

Have we done channel auto-create implementation yet? Because my PR was only on broker ingress.

@dsimansk I added it here: knative/eventing#7089

Copy link
Contributor

@dsimansk dsimansk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Cali0707!

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Aug 1, 2023
@knative-prow
Copy link

knative-prow bot commented Aug 1, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cali0707, dsimansk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 1, 2023
@knative-prow knative-prow bot merged commit a52897a into knative:main Aug 1, 2023
@dsimansk
Copy link
Contributor

dsimansk commented Aug 1, 2023

/cherry-pick release-1.11

@knative-prow-robot
Copy link
Contributor

@dsimansk: new pull request created: #5645

In response to this:

/cherry-pick release-1.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants