-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added mention of channels to event type autocreate docs #5639
Added mention of channels to event type autocreate docs #5639
Conversation
Signed-off-by: Calum Murray <cmurray@redhat.com>
✅ Deploy Preview for knative ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
/cc @matzew |
@matzew do you think it is worth adding an example of using this with a channel as well, or is this enough to show that it works with channels as well? |
Have we done channel auto-create implementation yet? Because my PR was only on broker ingress. |
@dsimansk I added it here: knative/eventing#7089 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Cali0707!
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Cali0707, dsimansk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherry-pick release-1.11 |
@dsimansk: new pull request created: #5645 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This adds mention of eventtype auto create supporting the channel as well as the broker.
Proposed Changes