Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document QP reporting period #5582

Merged
merged 2 commits into from
May 30, 2023
Merged

Conversation

skonto
Copy link
Contributor

@skonto skonto commented May 30, 2023

Proposed Changes

@netlify
Copy link

netlify bot commented May 30, 2023

Deploy Preview for knative ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit d9659ff
🔍 Latest deploy log https://app.netlify.com/sites/knative/deploys/6475cabd5694e500082a6615
😎 Deploy Preview https://deploy-preview-5582--knative.netlify.app/docs/serving/services/service-metrics
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@knative-prow knative-prow bot requested review from nainaz and psschwei May 30, 2023 09:56
@knative-prow knative-prow bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 30, 2023
@skonto
Copy link
Contributor Author

skonto commented May 30, 2023

/assign @dprotaso

@dprotaso
Copy link
Member

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label May 30, 2023
@knative-prow
Copy link

knative-prow bot commented May 30, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, skonto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 1be1ddf into knative:main May 30, 2023
@dprotaso
Copy link
Member

/cherry-pick release-1.10

@knative-prow-robot
Copy link
Contributor

@dprotaso: #5582 failed to apply on top of branch "release-1.10":

Applying: document qp reporting period
Using index info to reconstruct a base tree...
M	docs/serving/services/service-metrics.md
Falling back to patching base and 3-way merge...
Auto-merging docs/serving/services/service-metrics.md
CONFLICT (content): Merge conflict in docs/serving/services/service-metrics.md
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 document qp reporting period
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-1.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants