Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update config elements for eventing channel and pingsource #4453

Conversation

odacremolbap
Copy link

@odacremolbap odacremolbap commented Nov 8, 2021

"Fixes #issue-number" or "Add description of the problem this PR solves"

Proposed Changes

Previous configuration element names are still processed the same but we want the new ones to be the only reference to users.

MERGEABLE since related PR at knative/eventing#5875 got merged.

@knative-prow-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@knative-prow-robot knative-prow-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 8, 2021
@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Nov 8, 2021
@netlify
Copy link

netlify bot commented Nov 8, 2021

✔️ Deploy Preview for knative ready!

🔨 Explore the source changes: c4a3359

🔍 Inspect the deploy log: https://app.netlify.com/sites/knative/deploys/6189384808dc950008a37c60

😎 Browse the preview: https://deploy-preview-4453--knative.netlify.app

@knative-prow-robot knative-prow-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 8, 2021
@odacremolbap odacremolbap marked this pull request as ready for review December 17, 2021 07:47
@knative-prow-robot knative-prow-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 17, 2021
@odacremolbap
Copy link
Author

/assign @csantanapr

@csantanapr
Copy link
Member

/approve
/lgtm

For others to be aware, the change in eventing just got merged, and this doc update should not be cherry-picked.

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 17, 2021
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: csantanapr, odacremolbap

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 17, 2021
@knative-prow-robot knative-prow-robot merged commit 82f9174 into knative:main Dec 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants