Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation for KReference.Group feature #3713

Merged
merged 5 commits into from
Jun 16, 2021
Merged

Documentation for KReference.Group feature #3713

merged 5 commits into from
Jun 16, 2021

Conversation

slinkydeveloper
Copy link
Contributor

Signed-off-by: Francesco Guardiani francescoguard@gmail.com

Proposed Changes

@slinkydeveloper
Documentation for KReference.Group feature
ff56577 
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Jun 3, 2021
@knative-prow-robot knative-prow-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 3, 2021
@slinkydeveloper
Copy link
Contributor Author

/hold

This is ready for review but the approval requires the approval of knative/eventing#5440 first

@knative-prow-robot knative-prow-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 3, 2021
This was referenced Jun 3, 2021
Merged
Open
@netlify
Copy link

netlify bot commented Jun 3, 2021 •
edited
Loading

✔️ Deploy Preview for dev-knative ready!

🔨 Explore the source changes: 882d6ae

🔍 Inspect the deploy log: https://app.netlify.com/sites/dev-knative/deploys/60c860f8e15cf70008a04cad

😎 Browse the preview: https://deploy-preview-3713--dev-knative.netlify.app/development/eventing/experimental-features

rhuss
rhuss reviewed Jun 4, 2021
View reviewed changes
Copy link
Contributor

@rhuss rhuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in general but could elaborate a bit why to prefer group: over apiVersion: like you do in the description of the implementation PR ?

@slinkydeveloper
Explain why
30a5f93 
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
@slinkydeveloper
Copy link
Contributor Author

@rhuss last commit should explain the "why", lmk how it sounds

abrennan89
abrennan89 reviewed Jun 4, 2021
View reviewed changes
Copy link
Contributor

@abrennan89 abrennan89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some suggestions

@slinkydeveloper
Suggestions
377710f 
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
abrennan89
abrennan89 approved these changes Jun 7, 2021
View reviewed changes
Copy link
Contributor

@abrennan89 abrennan89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 7, 2021
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abrennan89, slinkydeveloper

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 7, 2021
@abrennan89 abrennan89 added this to the v0.24.0 milestone Jun 7, 2021
@slinkydeveloper
Added link issue
4ef9537 
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
@knative-prow-robot knative-prow-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 7, 2021
@abrennan89
Copy link
Contributor

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 7, 2021
@slinkydeveloper slinkydeveloper mentioned this pull request Jun 14, 2021
Open
8 tasks
@slinkydeveloper
State -> Stage
882d6ae 
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
@knative-prow-robot knative-prow-robot removed the lgtm Indicates that a PR is ready to be merged. label Jun 15, 2021
@slinkydeveloper
Copy link
Contributor Author

/unhold

@knative-prow-robot knative-prow-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 16, 2021
@slinkydeveloper
Copy link
Contributor Author

@abrennan89 can you lgtm it again? :)

@abrennan89
Copy link
Contributor

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 16, 2021
@knative-prow-robot knative-prow-robot merged commit 0ad571f into knative:mkdocs Jun 16, 2021
@slinkydeveloper slinkydeveloper deleted the kreference-group branch June 17, 2021 06:00
RichardJJG pushed a commit to RichardJJG/docs that referenced this pull request Jul 1, 2021
@slinkydeveloper @RichardJJG
Documentation for KReference.Group feature (knative#3713)
cd28fee 
* Documentation for KReference.Group feature

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

* Explain why

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

* Suggestions

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

* Added link issue

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

* State -> Stage

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhuss rhuss rhuss left review comments

@abrennan89 abrennan89 abrennan89 approved these changes

Assignees

@abrennan89 abrennan89

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. kind/mkdocs lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v0.24.0
Development

Successfully merging this pull request may close these issues.
5 participants
@slinkydeveloper @knative-prow-robot @abrennan89 @rhuss @omerbensaadon