Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace service.yaml with the correct contents #1378

Merged
merged 4 commits into from
Jun 25, 2019
Merged

Replace service.yaml with the correct contents #1378

merged 4 commits into from
Jun 25, 2019

Conversation

houshengbo
Copy link
Contributor

@houshengbo houshengbo commented May 28, 2019 •
edited
Loading

Fixes #1312

Proposed Changes

  • Replace service.yaml with the correct contents
  • Add the requirement for a public domain name for the service

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label May 28, 2019
@knative-prow-robot knative-prow-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 28, 2019
@knative-prow-robot
Copy link
Contributor

Hi @houshengbo. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot knative-prow-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 28, 2019
@houshengbo
Copy link
Contributor Author

/assign @gyliu513 @carieshmarie

gyliu513
gyliu513 reviewed May 28, 2019
View reviewed changes
docs/serving/samples/gitwebhook-go/README.md Outdated
@@ -10,6 +10,10 @@ webhook.
and a Docker Hub account configured (we'll use it for a container registry).
- An account on [GitHub](https://github.com) with read/write access to a
repository.
- A public domain name available over the internet for your service to run this
example, if you use the repository in github.com to send a payload to your
webhook service. Check the guidance on how to get one for your service
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you help add a link to the guidance?

Copy link
Contributor Author

@houshengbo houshengbo May 28, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Each cloud provider should have its own guidance. I have not investigated all of them. It should be the user's duty to search for it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make sense, thanks.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Step 6 further down actually points to the doc about configuring a custom domain and assigning a static IP to it. I think we should bring that information to the sentence that you just added.

@gyliu513
Copy link
Contributor

/ok-to-test

@knative-prow-robot knative-prow-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 28, 2019
gyliu513
gyliu513 reviewed May 29, 2019
View reviewed changes
docs/serving/samples/gitwebhook-go/README.md Outdated
@@ -10,6 +10,10 @@ webhook.
and a Docker Hub account configured (we'll use it for a container registry).
- An account on [GitHub](https://github.com) with read/write access to a
repository.
- A public domain name available over the internet for your service to run this
example, if you use the repository in github.com to send a payload to your
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/github.com/GitHub

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

docs/serving/samples/gitwebhook-go/README.md Outdated
@@ -10,6 +10,10 @@ webhook.
and a Docker Hub account configured (we'll use it for a container registry).
- An account on [GitHub](https://github.com) with read/write access to a
repository.
- A public domain name available over the internet for your service to run this
example, if you use the repository in github.com to send a payload to your
webhook service. Check the guidance on how to get one for your service
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make sense, thanks.

@gyliu513
Copy link
Contributor

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label May 29, 2019
@houshengbo
Copy link
Contributor Author

houshengbo commented May 30, 2019 •
edited
Loading

/assign @carieshmarie @sebgoa

@knative-prow-robot knative-prow-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 30, 2019
@RichieEscarez
Copy link
Contributor

I did a quick edit to make clear that owning a domain is a prereq and also fixed some steps, links, and PR #1202

PTAL to ensure technical accuracy and then I can approve/merge

RichieEscarez
RichieEscarez reviewed Jun 13, 2019
View reviewed changes
docs/serving/samples/gitwebhook-go/README.md Outdated
- You must ensure that your Knative cluster uses a static IP address:
- For Google Kubernetes Engine, see
[assigning a static IP address](../../gke-assigning-static-ip-address.md).
- For other cloud provider, refer to your provider's documentation.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- For other cloud provider, refer to your provider's documentation.
- For other cloud providers, refer to your provider's documentation.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@RichieEscarez
Copy link
Contributor

A few more edits but otherwise this looks good to me. Ill mark 'approved' once my suggestions are committed.

Can @sebgoa or @gyliu513 provide the LGTM?

Vincent Hou and others added 4 commits June 20, 2019 20:59
@gyliu513
Copy link
Contributor

/lgtm

Thanks @houshengbo

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 21, 2019
@samodell
Copy link
Contributor

/approve

@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: houshengbo, samodell

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit 97b3c20 into knative:master Jun 25, 2019
RichieEscarez added a commit to RichieEscarez/docs that referenced this pull request Jun 26, 2019
@RichieEscarez
Replace service.yaml with the correct contents (knative#1378)
daf4456 
* Replace service.yaml with the correct contents

* edit for clarity, domain as req., PR knative#1202

* Update docs/serving/samples/gitwebhook-go/README.md

Co-Authored-By: RichieEscarez <rescarez@google.com>

* Apply suggestions from code review

Co-Authored-By: RichieEscarez <rescarez@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebgoa sebgoa sebgoa left review comments

@gyliu513 gyliu513 gyliu513 left review comments

@RichieEscarez RichieEscarez RichieEscarez left review comments

@carieshmarie carieshmarie Awaiting requested review from carieshmarie

Assignees

@gyliu513 gyliu513

@RichieEscarez RichieEscarez

Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Failed to set up the webhook in Github for gitwebhook-go sample
8 participants
@houshengbo @knative-prow-robot @gyliu513 @RichieEscarez @samodell @sebgoa @googlebot @carieshmarie