Document auto-create feature flag for EventType creation #5612
Assignees
Comments
|
/assign @dsimansk |
|
Eventing PR ref: knative/eventing#7034 |
5 tasks
knative-prow bot
pushed a commit
to knative/eventing
that referenced
this issue
Jun 27, 2023
Fixes #6909 <!-- Please include the 'why' behind your changes if no issue exists --> I still need to add unit tests, but I'd like to get any feedback wrt/ code structure and overall approach. Thx. /cc @matzew @pierDipi ## Proposed Changes <!-- Please categorize your changes: - 🎁 Add new feature - 🐛 Fix bug - 🧹 Update or clean up current behavior - 🗑️ Remove feature or internal logic --> - Add handler to auto create Event Types - Add feature flag to gate it ### Pre-review Checklist <!-- If these boxes are not checked, you will be asked to complete these requirements or explain why they do not apply to your PR. --> - [ ] **At least 80% unit test coverage** - [ ] **E2E tests** for any new behavior - [ ] **Docs PR** for any user-facing impact - [ ] **Spec PR** for any new API feature - [ ] **Conformance test** for any change to the spec **Release Note** <!-- 📄 If this change has user-visible impact, write a release note in the block below. Include the string "action required" if additional action is required of users switching to the new release, for example in case of a breaking change. Write as if you are speaking to users, not other Knative contributors. If this change has no user-visible impact, no release note is needed. --> ```release-note Even Type auto-create feature: - Feature flag to enable: `eventtype-auto-create` in `configmap/config-features` - Based on CloudEvents processed in a broker corresponding `EventType` resources are created in the namespace ``` **Docs** The doc issue to track: knative/docs#5612 <!-- :book: If this change has user-visible impact, link to an issue or PR in https://github.com/knative/docs. --> --------- Co-authored-by: Matthias Wessendorf <mwessend@redhat.com> Co-authored-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>
vishal-chdhry
pushed a commit
to vishal-chdhry/eventing
that referenced
this issue
Jul 6, 2023
Fixes knative#6909 <!-- Please include the 'why' behind your changes if no issue exists --> I still need to add unit tests, but I'd like to get any feedback wrt/ code structure and overall approach. Thx. /cc @matzew @pierDipi <!-- Please categorize your changes: - 🎁 Add new feature - 🐛 Fix bug - 🧹 Update or clean up current behavior - 🗑️ Remove feature or internal logic --> - Add handler to auto create Event Types - Add feature flag to gate it <!-- If these boxes are not checked, you will be asked to complete these requirements or explain why they do not apply to your PR. --> - [ ] **At least 80% unit test coverage** - [ ] **E2E tests** for any new behavior - [ ] **Docs PR** for any user-facing impact - [ ] **Spec PR** for any new API feature - [ ] **Conformance test** for any change to the spec **Release Note** <!-- 📄 If this change has user-visible impact, write a release note in the block below. Include the string "action required" if additional action is required of users switching to the new release, for example in case of a breaking change. Write as if you are speaking to users, not other Knative contributors. If this change has no user-visible impact, no release note is needed. --> ```release-note Even Type auto-create feature: - Feature flag to enable: `eventtype-auto-create` in `configmap/config-features` - Based on CloudEvents processed in a broker corresponding `EventType` resources are created in the namespace ``` **Docs** The doc issue to track: knative/docs#5612 <!-- :book: If this change has user-visible impact, link to an issue or PR in https://github.com/knative/docs. --> --------- Co-authored-by: Matthias Wessendorf <mwessend@redhat.com> Co-authored-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>
5 tasks
knative-prow bot
pushed a commit
to knative/eventing
that referenced
this issue
Jul 25, 2023
Fixes #7044 <!-- Please include the 'why' behind your changes if no issue exists --> ## Proposed Changes <!-- Please categorize your changes: - 🎁 Add new feature - 🐛 Fix bug - 🧹 Update or clean up current behavior - 🗑️ Remove feature or internal logic --> - Refactor `eventtypes.go` and `eventtypes_test.go` out of the `broker` package into their own package to facilitate sharing code with channels. - Use the auto create funcionality from the `eventtypes` package in the fanout message handler to autocreate event types. ### Pre-review Checklist <!-- If these boxes are not checked, you will be asked to complete these requirements or explain why they do not apply to your PR. --> - [ ] **At least 80% unit test coverage** - [ ] **E2E tests** for any new behavior - [ ] **Docs PR** for any user-facing impact - [ ] **Spec PR** for any new API feature - [ ] **Conformance test** for any change to the spec **Release Note** <!-- 📄 If this change has user-visible impact, write a release note in the block below. Include the string "action required" if additional action is required of users switching to the new release, for example in case of a breaking change. Write as if you are speaking to users, not other Knative contributors. If this change has no user-visible impact, no release note is needed. --> ```release-note Even Type auto-create feature: - Based on CloudEvents processed in an inmemorychannel corresponding `EventType` resources are created in the namespace ``` **Docs** <!-- 📖 If this change has user-visible impact, link to an issue or PR in https://github.com/knative/docs. --> Tracking issue for docs: knative/docs#5612
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
With the release 1.11 there will be a feature flag to have "auto created" event types, when emitting to the Knative Reference broker.
This should be documented.
The text was updated successfully, but these errors were encountered: