This repository has been archived by the owner on Sep 5, 2019. It is now read-only.
Propagate the labels form the build on the pod #559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows users to specify custom labels.
ccojocar
changed the title
|
@imjasonh Any chance to have a look over this PR? Thanks |
|
/ok-to-test |
|
The following is the coverage report on pkg/.
|
|
/retest |
|
@vdemeester The tests passed after rebasing. Please could have a look if it can be merged? Thanks |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ccojocar, ImJasonH The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test pull-knative-build-integration-tests |
vdemeester
pushed a commit
to vdemeester/knative-build
that referenced
this pull request
Apr 3, 2019
* Propagate the labels from the build to the pod This allows users to specify custom labels. * Fix typo in comment
vdemeester
pushed a commit
to vdemeester/knative-build
that referenced
this pull request
Apr 3, 2019
* Propagate the labels from the build to the pod This allows users to specify custom labels. * Fix typo in comment
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows usrs to specify custom labels.