This repository has been archived by the owner on Sep 5, 2019. It is now read-only.
Add PodSecurityPolicy #515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/ok-to-test |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danielpeach, ImJasonH The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
imjasonh
added a commit
to imjasonh/pipeline
that referenced
this pull request
Apr 1, 2019
This defines a minimal PodSecurityPolicy needed for Tekton to run on the cluster. This enables Tekton to run in clusters where PSPs are enforced and where another more restrictive PSP might be defined elsewhere. This mirrors knative/build#515
tekton-robot
pushed a commit
to tektoncd/pipeline
that referenced
this pull request
Apr 2, 2019
This defines a minimal PodSecurityPolicy needed for Tekton to run on the cluster. This enables Tekton to run in clusters where PSPs are enforced and where another more restrictive PSP might be defined elsewhere. This mirrors knative/build#515
vdemeester
pushed a commit
to vdemeester/knative-build
that referenced
this pull request
Apr 3, 2019
vdemeester
pushed a commit
to vdemeester/knative-build
that referenced
this pull request
Apr 3, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #509
Proposed Changes
knative-buildcomponents.Unfortunately, we have to allow
build-webhookto run as root (seerunAsUser.rule: 'RunAsAny'below), since it serves on443. Ideally we'd whitelistCAP_NET_BIND_SERVICEand not run as root, but thecapabilitiesoption for PodSecurityPolicies does not work as expected: kubernetes/kubernetes#56374.