Skip to content
This repository has been archived by the owner on Sep 5, 2019. It is now read-only.

Introduction of the declaration about Contributor Covenant Code of C… #462

Merged
merged 1 commit into from
Nov 11, 2018

Conversation

zouyee
Copy link

@zouyee zouyee commented Nov 9, 2018

Fixes #461
Introduction of the declaration about Contributor Covenant Code of Conduct.

Proposed Changes

Release Note

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@knative-prow-robot
Copy link

Hi @zouyee. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@mattmoor mattmoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have this under our docs repo for the whole organization: https://github.com/knative/docs/blob/master/community/CODE-OF-CONDUCT.md

Can you just make this link there?

Copy link
Member

@imjasonh imjasonh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like Serving has it, so we should too.

/ok-to-test
/lgtm
/approve

@knative-prow-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ImJasonH, zouyee

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zouyee
Copy link
Author

zouyee commented Nov 11, 2018

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@knative-prow-robot knative-prow-robot merged commit dec41c6 into knative:master Nov 11, 2018
mgencur pushed a commit to mgencur/knative-build that referenced this pull request Nov 13, 2018
vdemeester pushed a commit to vdemeester/knative-build that referenced this pull request Apr 3, 2019
vdemeester pushed a commit to vdemeester/knative-build that referenced this pull request Apr 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants