Skip to content
This repository has been archived by the owner on Sep 5, 2019. It is now read-only.

Use custom nop image instead of busybox #371

Merged
merged 1 commit into from
Sep 21, 2018

Conversation

imjasonh
Copy link
Member

Proposed Changes

  • Build a custom image with Go binary that prints Build successful and exits
  • Specify this image to the controller by flag
  • Use this image instead of busybox running echo Build successful
  • Cache this image

Release Note

@knative-metrics-robot
Copy link

The following is the coverage report on pkg/.
Say /test pull-knative-build-go-coverage to run the coverage report again

File Old Coverage New Coverage Delta
pkg/builder/cluster/convert/convert.go 85.3% 85.2% -0.1

Copy link
Contributor

@shashwathi shashwathi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

More of a cleanup suggestion

  • ToCRD function is used only in test, does it make more sense to have either test_helper package or move that helper function into test package?

@knative-prow-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ImJasonH, shashwathi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit 0f706d6 into knative:master Sep 21, 2018
vdemeester pushed a commit to vdemeester/knative-build that referenced this pull request Apr 3, 2019
vdemeester pushed a commit to vdemeester/knative-build that referenced this pull request Apr 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants