Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #1223

Merged

Conversation

creydr
Copy link
Contributor

@creydr creydr commented Sep 11, 2023

Update dependencies and fix build issues which came after some change in knative/eventing#7237

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 11, 2023
@knative-prow knative-prow bot requested review from bbtong and salaboy September 11, 2023 10:20
@knative-prow knative-prow bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 11, 2023
@creydr creydr requested review from gabo1208 and removed request for salaboy and bbtong September 11, 2023 10:20
@codecov
Copy link

codecov bot commented Sep 11, 2023

Codecov Report

Merging #1223 (ac315d4) into main (1b27f43) will increase coverage by 0.10%.
The diff coverage is 83.33%.

@@            Coverage Diff             @@
##             main    #1223      +/-   ##
==========================================
+ Coverage   74.64%   74.75%   +0.10%     
==========================================
  Files          44       44              
  Lines        3427     3430       +3     
==========================================
+ Hits         2558     2564       +6     
+ Misses        768      765       -3     
  Partials      101      101              
Files Changed Coverage Δ
pkg/reconciler/broker/broker_test_helper.go 82.94% <66.66%> (+2.32%) ⬆️
pkg/reconciler/broker/broker.go 86.26% <100.00%> (+0.14%) ⬆️

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Sep 11, 2023
@knative-prow
Copy link

knative-prow bot commented Sep 11, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: creydr, gabo1208

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gabo1208
Copy link
Contributor

Thanks @creydr !

@knative-prow knative-prow bot merged commit 724da2b into knative-extensions:main Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants