Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes the deprecated DeadLetterChannel in ChannelableStatus #389

Conversation

vishal-chdhry
Copy link

Signed-off-by: Vishal Choudhary sendtovishalchoudhary@gmail.com

Fixes #388
Context:

Proposed Changes

  • 🗑️ Remove feature or internal logic
  • removes deprecated DeadLetterChannel

Pre-review Checklist

  • At least 80% unit test coverage
  • E2E tests for any new behavior
  • Docs PR for any user-facing impact
  • Spec PR for any new API feature
  • Conformance test for any change to the spec

Release Note

removes deprecated DeadLetterChannel in favor of DeliveryStatus

Docs

Signed-off-by: Vishal Choudhary <sendtovishalchoudhary@gmail.com>
@knative-prow
Copy link

knative-prow bot commented Feb 9, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Vishal-Chdhry
Once this PR has been reviewed and has the lgtm label, please assign matzew for approval by writing /assign @matzew in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow
Copy link

knative-prow bot commented Feb 9, 2023

Welcome @vishal-chdhry! It looks like this is your first PR to knative-sandbox/eventing-natss 🎉

@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 9, 2023
@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 28, 2023
@knative-prow-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Get rid of the removed DeadLetterChannel in ChannelableStatus
2 participants