[release-1.11] Update the updateServerConfig function to pass in the cert value diectly #3358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…roker/receiver/impl/ReceiverVerticle.java Co-authored-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>
knative-prow
bot
added
area/data-plane
size/M
Codecov Report
@@ Coverage Diff @@
## release-1.11 #3358 +/- ##
=============================================
Coverage 58.50% 58.50%
=============================================
Files 91 91
Lines 9161 9161
=============================================
Hits 5360 5360
Misses 3380 3380
Partials 421 421 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: knative-prow-robot, pierDipi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow
bot
added
the
approved
pierDipi
added a commit
to pierDipi/eventing-kafka-broker
that referenced
this pull request
Sep 29, 2023
…cert value diectly (knative-extensions#3358) * Update the updateServerConfig function to pass in the cert value directly * Update the implementation of receiverVerticle * Fix the comments * Update data-plane/receiver/src/main/java/dev/knative/eventing/kafka/broker/receiver/impl/ReceiverVerticle.java Co-authored-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com> --------- Co-authored-by: Leo Li <leoli@redhat.com> Co-authored-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>
Leo6Leo
added a commit
to Leo6Leo/eventing-kafka-broker
that referenced
this pull request
Sep 29, 2023
…cert value diectly (knative-extensions#3358) * Update the updateServerConfig function to pass in the cert value directly * Update the implementation of receiverVerticle * Fix the comments * Update data-plane/receiver/src/main/java/dev/knative/eventing/kafka/broker/receiver/impl/ReceiverVerticle.java Co-authored-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com> --------- Co-authored-by: Leo Li <leoli@redhat.com> Co-authored-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>
Leo6Leo
added a commit
to Leo6Leo/eventing-kafka-broker
that referenced
this pull request
Sep 29, 2023
…cert value diectly (knative-extensions#3358) * Update the updateServerConfig function to pass in the cert value directly * Update the implementation of receiverVerticle * Fix the comments * Update data-plane/receiver/src/main/java/dev/knative/eventing/kafka/broker/receiver/impl/ReceiverVerticle.java Co-authored-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com> --------- Co-authored-by: Leo Li <leoli@redhat.com> Co-authored-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>
openshift-ci bot
pushed a commit
to openshift-knative/eventing-kafka-broker
that referenced
this pull request
Oct 5, 2023
…cert value diectly (knative-extensions#3358) (#838) * Update the updateServerConfig function to pass in the cert value directly * Update the implementation of receiverVerticle * Fix the comments * Update data-plane/receiver/src/main/java/dev/knative/eventing/kafka/broker/receiver/impl/ReceiverVerticle.java --------- Co-authored-by: Knative Prow Robot <knative-prow-robot@google.com> Co-authored-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #3337