Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make SecretSpec field of consumers Auth omitempty #3286

Merged
merged 1 commit into from
Aug 15, 2023

Conversation

mgencur
Copy link
Contributor

@mgencur mgencur commented Aug 15, 2023

This will prevent writing SecretSpec with null value and the webhook will rather omit the element.

 spec:
        auth:
          SecretSpec: null

Having the element there with null value can also caus problems during downgrades when the element was not there yet (it's a few versions back though)

Proposed Changes

Release Note


Docs

@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 15, 2023
@codecov
Copy link

codecov bot commented Aug 15, 2023

Codecov Report

Merging #3286 (5cf465d) into main (842eb1c) will increase coverage by 3.23%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #3286      +/-   ##
============================================
+ Coverage     58.56%   61.80%   +3.23%     
- Complexity        0      765     +765     
============================================
  Files            91      181      +90     
  Lines          9159    12220    +3061     
  Branches          0      266     +266     
============================================
+ Hits           5364     7552    +2188     
- Misses         3375     4080     +705     
- Partials        420      588     +168     
Flag Coverage Δ
java-unittests 71.57% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...nternals/kafka/eventing/v1alpha1/consumer_types.go 72.97% <ø> (ø)

... and 91 files with indirect coverage changes

Copy link
Contributor

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Aug 15, 2023
@knative-prow
Copy link

knative-prow bot commented Aug 15, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matzew, mgencur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 15, 2023
@knative-prow knative-prow bot merged commit 54a845c into knative-extensions:main Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/control-plane lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants