Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.11] Fixed composite prober logic #3278

Conversation

knative-prow-robot
Copy link
Contributor

This is an automated cherry-pick of #3273

fixed the prober logic for addresses which could be http or https

Signed-off-by: Calum Murray <cmurray@redhat.com>
@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 8, 2023
@Cali0707
Copy link
Member

Cali0707 commented Aug 8, 2023

/cc @matzew @creydr

@knative-prow knative-prow bot requested review from creydr and matzew August 8, 2023 13:07
@codecov
Copy link

codecov bot commented Aug 8, 2023

Codecov Report

Merging #3278 (eac089f) into release-1.11 (fa29029) will increase coverage by 21.61%.
The diff coverage is n/a.

@@                 Coverage Diff                 @@
##             release-1.11    #3278       +/-   ##
===================================================
+ Coverage           58.52%   80.14%   +21.61%     
- Complexity              0      774      +774     
===================================================
  Files                  91       79       -12     
  Lines                9157     2800     -6357     
  Branches                0      250      +250     
===================================================
- Hits                 5359     2244     -3115     
+ Misses               3377      400     -2977     
+ Partials              421      156      -265     
Flag Coverage Δ
java-unittests 80.14% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 170 files with indirect coverage changes

@Cali0707
Copy link
Member

Cali0707 commented Aug 8, 2023

/retest-required

Copy link
Contributor

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Aug 9, 2023
@knative-prow
Copy link

knative-prow bot commented Aug 9, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: knative-prow-robot, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 9, 2023
@knative-prow knative-prow bot merged commit c36e344 into knative-extensions:release-1.11 Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/control-plane lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants