Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Event Filtering: Benchmark Java Implementation of "All" filter #3236

Closed
Cali0707 opened this issue Jul 26, 2023 · 10 comments · Fixed by #3362
Closed

New Event Filtering: Benchmark Java Implementation of "All" filter #3236

Cali0707 opened this issue Jul 26, 2023 · 10 comments · Fixed by #3362
Assignees
Labels
area/data-plane area/test good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature-request triage/accepted Issues which should be fixed (post-triage)

Comments

@Cali0707
Copy link
Member

Cali0707 commented Jul 26, 2023

Problem
To move New Event Filtering into beta, we should benchmark the "All" SubscriptionsAPI filter implementation.

To add a benchmark for a new type of filter, add a file to this folder for the filter type, and then follow the pattern in https://github.com/knative-extensions/eventing-kafka-broker/pull/3247/files#diff-b300a22e800560bd785d1c686237dbd3bc39979e85ef6699adbbbec58e2101ca. Specifically, when making a new benchmark, you need to extend the FilterBenchmark class and override the createEvent and createFilter functions to create the desired event and filter to benchmark.

Exit Criteria
Benchmarks measuring performance of the "All" filter with combinations of all of the other types of SubscriptionsAPI filters

Time Estimate (optional):
How many developer-days do you think this may take to resolve? 2

Additional context (optional)

@Cali0707
Copy link
Member Author

/area data-plane
/area test

@Cali0707 Cali0707 changed the title New Event Filtering: Banchmark Java Implementation of "All" filter New Event Filtering: Benchmark Java Implementation of "All" filter Jul 26, 2023
@Cali0707
Copy link
Member Author

Note this is not ready to work until after #3233 is finished

@Cali0707
Copy link
Member Author

/triage accepted

@knative-prow knative-prow bot added the triage/accepted Issues which should be fixed (post-triage) label Jul 27, 2023
@Cali0707
Copy link
Member Author

/good-first-issue

@knative-prow
Copy link

knative-prow bot commented Aug 16, 2023

@Cali0707:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow knative-prow bot added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Aug 16, 2023
@AllMight2099
Copy link

Hi there!
I'm Nishanth, can I take this issue up?

@Cali0707
Copy link
Member Author

Hi @AllMight2099!

Feel free to give this issue a go, let me know if you have any questions as you work on it
/assign @AllMight2099

@Cali0707
Copy link
Member Author

Cali0707 commented Sep 7, 2023

Hey @AllMight2099 how is this going? Is there anything you need help with?

@AllMight2099
Copy link

Hi @Cali0707
Sorry about the delay, There were a few things that I had to take care of so I became a little sidetracked, I'll put in an update later today. I think I've understood everything, but will ping you if I get stuck or if I have any questions

@Cali0707
Copy link
Member Author

@AllMight2099 no worries at all! Just let me know if I can be of any assistance :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/data-plane area/test good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature-request triage/accepted Issues which should be fixed (post-triage)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants