-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Event Filtering: Benchmark Java Implementation of "All" filter #3236
Comments
/area data-plane |
Note this is not ready to work until after #3233 is finished |
/triage accepted |
/good-first-issue |
@Cali0707: Please ensure the request meets the requirements listed here. If this request no longer meets these requirements, the label can be removed In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Hi there! |
Hi @AllMight2099! Feel free to give this issue a go, let me know if you have any questions as you work on it |
Hey @AllMight2099 how is this going? Is there anything you need help with? |
Hi @Cali0707 |
@AllMight2099 no worries at all! Just let me know if I can be of any assistance :) |
Problem
To move New Event Filtering into beta, we should benchmark the "All" SubscriptionsAPI filter implementation.
To add a benchmark for a new type of filter, add a file to this folder for the filter type, and then follow the pattern in https://github.com/knative-extensions/eventing-kafka-broker/pull/3247/files#diff-b300a22e800560bd785d1c686237dbd3bc39979e85ef6699adbbbec58e2101ca. Specifically, when making a new benchmark, you need to extend the
FilterBenchmark
class and override thecreateEvent
andcreateFilter
functions to create the desired event and filter to benchmark.Exit Criteria
Benchmarks measuring performance of the "All" filter with combinations of all of the other types of SubscriptionsAPI filters
Time Estimate (optional):
How many developer-days do you think this may take to resolve? 2
Additional context (optional)
The text was updated successfully, but these errors were encountered: