We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hey,
in the redis store GetSession method, the statement that verifies that the retrieved handle form redis is not empty is dubious.
In the case the user has not provided an username, which he might do, then the session he opened can never be retrieved.
See this line https://github.com/knadh/niltalk/blob/master/store/redis/redis.go#L164
I have not run manual testing to check for it, though i had to remove the corresponding statement in the memory store i have written.
So i guess this applies to the redis store too.
The text was updated successfully, but these errors were encountered:
Ah yes. There should not be a session without a handle in the first place. A handle should be auto-generated if one's not specificied here: https://github.com/knadh/niltalk/blob/master/handlers.go#L115
Sorry, something went wrong.
fix knadh#19 automatically generate an user handle if it is empty
d235a35
5c21d5d
Merge pull request #22 from clementauger/fix#19
979fe77
Fix #19 automatically generate an user handle if it is empty
No branches or pull requests
hey,
in the redis store GetSession method, the statement that verifies that the retrieved handle form redis is not empty is dubious.
In the case the user has not provided an username, which he might do, then the session he opened can never be retrieved.
See this line https://github.com/knadh/niltalk/blob/master/store/redis/redis.go#L164
I have not run manual testing to check for it, though i had to remove the corresponding statement in the memory store i have written.
So i guess this applies to the redis store too.
The text was updated successfully, but these errors were encountered: