LSPのDiagnostics関連の修正とリファクタリング #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
atusy
commented
Jul 4, 2023
atusy
commented
- 重要なのは 5436fd6 でRawInlineが正しく出力されないバグを修正
- 他で無用なグローバル変数の除去や無用に複雑な関数のリファクタなどをしました
kmuto
reviewed
Jul 5, 2023
|
1箇所だけコメントしましたー(マージしてから直してもいいんですが、とりあえずここで)。 |
Co-authored-by: Kenshi Muto <kmuto@kmuto.jp>
|
あざます！ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.