Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check note status on upload #4

Closed
kmpoppe opened this issue Jun 10, 2020 · 0 comments
Closed

Check note status on upload #4

kmpoppe opened this issue Jun 10, 2020 · 0 comments
Assignees
@kmpoppe
Labels
enhancement New feature or request
Milestone
0.3.5

Comments

@kmpoppe
Copy link
Owner

kmpoppe commented Jun 10, 2020

noteSolver/notesolver/src/org/openstreetmap/josm/plugins/notesolver/NoteSolverPlugin.java

Line 206 in fca249f

for (Note note : rememberedNotes) {

Check the status of the note again right before upload. Unknown what happens, when an already closed note (outside JOSM) is closed again.
@kmpoppe kmpoppe added the enhancement New feature or request label Jun 10, 2020
@kmpoppe kmpoppe added this to the 0.4 milestone Jun 10, 2020
@kmpoppe kmpoppe self-assigned this Jun 10, 2020
@kmpoppe kmpoppe modified the milestones: 0.4, 0.3.5 Jun 10, 2020
kmpoppe added a commit that referenced this issue Jul 4, 2021
@kmpoppe
Update NoteSolverPlugin.java
404b0b2 
Closes #10 - created_by easy.
#4 can't be closed. It doesn't work when the note is solved outside because the Layer can't be updated. Will check back with josm-dev.
@kmpoppe kmpoppe closed this as completed in 414049e Jul 4, 2021
@kmpoppe kmpoppe mentioned this issue Mar 13, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kmpoppe kmpoppe

Labels
enhancement New feature or request
Projects
None yet
Milestone
0.3.5
Development

No branches or pull requests
1 participant
@kmpoppe