Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reading readme.txt as a file that contains utf-8. #1

Merged
merged 3 commits into from
Aug 13, 2015

Conversation

dimazest
Copy link
Contributor

Also reading the file inside of a context manager, as script installation might break on pypy when a lot of packages are being installed.

This brakes NLTK test installation for me...

dimazest added 2 commits July 24, 2015 18:01
Also reading the file inside of a context manager, as script installation might break on pypy when a lot of packages are being installed.
@kmike
Copy link
Owner

kmike commented Aug 1, 2015

I recall there was a problem: if you read non-ascii text as unicode then it doesn't work in Python 2.x, if you read it as bytes then it doesn't work in Python 3.x

@dimazest
Copy link
Contributor Author

dimazest commented Aug 2, 2015

That's funny.

Would it make sense to read the file differently depending on the python version?

@dimazest
Copy link
Contributor Author

Should be fine now.

kmike added a commit that referenced this pull request Aug 13, 2015
Reading readme.txt as a file that contains utf-8.
@kmike kmike merged commit a92e26a into kmike:master Aug 13, 2015
@kmike
Copy link
Owner

kmike commented Aug 13, 2015

Thanks! I've just released text-unidecode 1.0; could you please confirm it works for you?

@dimazest
Copy link
Contributor Author

Yes, NLTK tests work under both Python 2 and 3:

py27 installed: coverage==3.7.1,nltk==3.0.4,nose==1.3.7,numpy==1.9.2,text-unidecode==1.0,wheel==0.24.0

py34 installed: coverage==3.7.1,nltk==3.0.4,nose==1.3.7,numpy==1.9.2,scikit-learn==0.16.1,scipy==0.16.0,text-unidecode==1.0,wheel==0.24.0

@kmike
Copy link
Owner

kmike commented Aug 14, 2015

great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants