Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added instructions on how to become a member of the Kmesh community to the readme. #381

Merged
merged 2 commits into from
May 28, 2024

Conversation

LiZhenCheng9527
Copy link
Collaborator

What type of PR is this?

What this PR does / why we need it:
Added instructions on how to become a member of the Kmesh community to the readme.
Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@codecov-commenter
Copy link

codecov-commenter commented May 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Flag Coverage Δ
unittests 31.21% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

README.md Outdated

Responsibilities and related requirements for community roles can be found in [Membership doc](https://github.com/kmesh-net/website/blob/main/content/en/docs/community/membership.md).

If you want to become a member of the Kmesh community, you can start by submitting a [PR](https://github.com/kmesh-net/kmesh/blob/main/.github/ISSUE_TEMPLATE/membership-request.md) and then gradually fulfilling the conditions listed there.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is Issue not PR

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LiZhenCheng9527 LiZhenCheng9527 force-pushed the contributor branch 2 times, most recently from 9beae6b to 4c0fda0 Compare May 27, 2024 11:50
@kmesh-bot kmesh-bot added size/L and removed size/XS labels May 27, 2024
…o the readme

Signed-off-by: LiZhenCheng9527 <lizhencheng6@huawei.com>
Signed-off-by: LiZhenCheng9527 <lizhencheng6@huawei.com>
@kmesh-bot kmesh-bot added size/M and removed size/XS labels May 28, 2024
Copy link
Member

@hzxuzhonghu hzxuzhonghu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thanks!

@kmesh-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hzxuzhonghu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kmesh-bot kmesh-bot merged commit db870aa into kmesh-net:main May 28, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants