Fix cleanup kmesh-cni failed bug #367
Conversation
Signed-off-by: kangmingfa <1640528278@qq.com>
Codecov ReportAttention: Patch coverage is ❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Flags with carried forward coverage won't be shown. Click here to find out more.
|
pkg/cni/install.go
Outdated
| @@ -80,7 +80,7 @@ func (i *Installer) Stop() { | |||
| if i.Mode == constants.AdsMode || i.Mode == constants.WorkloadMode { | |||
| log.Info("start remove CNI config\n") | |||
| if err := i.removeCniConfig(); err != nil { | |||
| log.Error("remove CNI config failed, please remove manual") | |||
| log.Errorf("err:%v, remove CNI config failed, please remove manual", err) | |||
There was a problem hiding this comment.
In line 81 of the log, a newline character was added. Does it need to be added here? What is the standard for adding or not adding newline characters in Kmesh logs?
There was a problem hiding this comment.
we donot need to add \n by hand, becasue log.Errorf/Info/Debug has also added \n implicitly
pkg/cni/install.go
Outdated
| @@ -80,7 +80,7 @@ func (i *Installer) Stop() { | |||
| if i.Mode == constants.AdsMode || i.Mode == constants.WorkloadMode { | |||
| log.Info("start remove CNI config\n") | |||
| if err := i.removeCniConfig(); err != nil { | |||
| log.Error("remove CNI config failed, please remove manual") | |||
| log.Errorf("err:%v, remove CNI config failed, please remove manual", err) | |||
There was a problem hiding this comment.
we donot need to add \n by hand, becasue log.Errorf/Info/Debug has also added \n implicitly
Co-authored-by: Tiger Xu / Zhonghu Xu <xuzhonghu@huawei.com>
|
/lgtm /approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hzxuzhonghu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
What this PR does / why we need it:
Fix cleanup kmesh-cni failed bug.
Which issue(s) this PR fixes:
Fixes #365
Special notes for your reviewer:
Does this PR introduce a user-facing change?: